Page MenuHomeFreeBSD

sound tests: Fix 32bit calculation detection in pcm_read_write
ClosedPublic

Authored by dev_submerge.ch on Jan 23 2025, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 10:36 AM
Unknown Object (File)
Sun, Feb 23, 5:04 AM
Unknown Object (File)
Mon, Feb 17, 12:59 AM
Unknown Object (File)
Fri, Feb 14, 1:09 PM
Unknown Object (File)
Wed, Feb 12, 6:58 PM
Unknown Object (File)
Feb 3 2025, 1:40 PM
Unknown Object (File)
Feb 3 2025, 1:10 PM
Unknown Object (File)
Feb 1 2025, 2:16 AM
Subscribers

Details

Summary

Fix a mistake in the pcm_read_write test that would result in not
properly detecting 32bit calculation on 32bit architectures like i386.
As a consequence, the wrong values would be checked, thus failing the
test.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

To the best of my knowledge, this should fix the test on i386. I haven't spotted any other test failures yet on CI, but that's not conclusive - some architectures seem to have build failures and won't run the tests.

LGTM. I just saw that https://ci.freebsd.org/job/FreeBSD-main-i386-test/lastUnstableBuild/testReport/junit/sys.sound/pcm_read_write/pcm_read/ reported this error, as a result of the 32 -> 24 bit conversion not happening.

EDIT: Seems like you linked to this as well yesterday. :-)

This revision is now accepted and ready to land.Jan 23 2025, 12:30 PM