Page MenuHomeFreeBSD
Differential D48332

open(2): allow O_PATH | O_CREAT
ClosedPublic
Actions

Authored by kib on Mon, Jan 6, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 4:32 PM
Unknown Object (File)
Sat, Jan 11, 4:21 AM
Unknown Object (File)
Sat, Jan 11, 3:40 AM
Unknown Object (File)
Sat, Jan 11, 2:13 AM
Unknown Object (File)
Fri, Jan 10, 7:42 AM
Unknown Object (File)
Fri, Jan 10, 5:27 AM
Unknown Object (File)
Fri, Jan 10, 3:05 AM
Unknown Object (File)
Fri, Jan 10, 1:20 AM
View All 21 Files
Subscribers
imp
olce

Details

Reviewers
markj
Commits
rG749b3b2c0629: path_test: adjust test for open(O_PATH | O_CREAT)
rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT
Summary

There is no reason to disallow creating the file opened for path.
More, it might be a useful feature together with O_EXCL.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Mon, Jan 6, 11:03 AM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jan 6, 11:03 AM
kib requested review of this revision.Mon, Jan 6, 11:03 AM
markj accepted this revision.Mon, Jan 6, 2:07 PM

At least tests/sys/file/path_test.c:path_io will need to be updated.

This revision is now accepted and ready to land.Mon, Jan 6, 2:07 PM
kib updated this revision to Diff 148843.Mon, Jan 6, 11:41 PM

Fix tests

This revision now requires review to proceed.Mon, Jan 6, 11:41 PM
markj accepted this revision.Tue, Jan 7, 2:10 AM
markj added inline comments.
tests/sys/file/path_test.c
691 ↗(On Diff #148843)

Just for good measure, I'd verify that the descriptor really is an O_PATH descriptor. For example, read(pathfd) should fail.

This revision is now accepted and ready to land.Tue, Jan 7, 2:10 AM
kib updated this revision to Diff 148852.Tue, Jan 7, 2:34 AM
kib marked an inline comment as done.

Check that O_PATH|O_CREAT returns O_PATH-kind of fd.

This revision now requires review to proceed.Tue, Jan 7, 2:34 AM
markj accepted this revision.Tue, Jan 7, 2:36 AM
This revision is now accepted and ready to land.Tue, Jan 7, 2:36 AM
Closed by commit rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT (authored by kib). · Explain WhyTue, Jan 7, 2:46 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT.
kib added a commit: rG749b3b2c0629: path_test: adjust test for open(O_PATH | O_CREAT).

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 148806

View Options

sys/kern/vfs_syscalls.c

Loading...