open(2): allow O_PATH | O_CREAT
ClosedPublic
Actions

Authored by kib on Jan 6 2025, 11:03 AM.

Details

Reviewers

Commits

rG749b3b2c0629: path_test: adjust test for open(O_PATH | O_CREAT)
rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT

Summary

There is no reason to disallow creating the file opened for path.
More, it might be a useful feature together with O_EXCL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 6 2025, 11:03 AM

Herald added subscribers: olce, imp. · View Herald TranscriptJan 6 2025, 11:03 AM

kib requested review of this revision.Jan 6 2025, 11:03 AM

At least tests/sys/file/path_test.c:path_io will need to be updated.

This revision is now accepted and ready to land.Jan 6 2025, 2:07 PM

Fix tests

This revision now requires review to proceed.Jan 6 2025, 11:41 PM

markj accepted this revision.Jan 7 2025, 2:10 AM

markj added inline comments.

tests/sys/file/path_test.c
691 ↗	(On Diff #148843)	Just for good measure, I'd verify that the descriptor really is an O_PATH descriptor. For example, read(pathfd) should fail.

This revision is now accepted and ready to land.Jan 7 2025, 2:10 AM

Check that O_PATH|O_CREAT returns O_PATH-kind of fd.

This revision now requires review to proceed.Jan 7 2025, 2:34 AM

markj accepted this revision.Jan 7 2025, 2:36 AM

This revision is now accepted and ready to land.Jan 7 2025, 2:36 AM

Closed by commit rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT (authored by kib). · Explain WhyJan 7 2025, 2:46 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGcc0d806f63e8: open(2): allow O_PATH | O_CREAT.

kib added a commit: rG749b3b2c0629: path_test: adjust test for open(O_PATH | O_CREAT).

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_syscalls.c

2 lines

Diff 148853

View Options

open(2): allow O_PATH | O_CREATClosedPublicActions