Page MenuHomeFreeBSD
Differential D4793

Reduce libstand Makefile duplication
ClosedPublic
Actions

Authored by emaste on Jan 5 2016, 2:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:06 PM
Unknown Object (File)
Tue, Apr 30, 5:06 PM
Unknown Object (File)
Tue, Apr 30, 5:06 PM
Unknown Object (File)
Tue, Apr 30, 12:09 PM
Unknown Object (File)
Jan 3 2024, 8:14 AM
Unknown Object (File)
Dec 20 2023, 12:52 AM
Unknown Object (File)
Dec 14 2023, 4:23 PM
Unknown Object (File)
Nov 2 2023, 12:51 PM
View All 47 Files
Subscribers
allanjude
grehan
imp

Details

Reviewers
grehan
jhb
allanjude
imp
Commits
rS293435: Reduce libstand Makefile duplication
Summary

Userboot's copy of the libstand Makefile had more extensive changes compared to the one in sys/boot/libstand32, but it turns out these are not intentional and we can just include lib/libstand/Makefile as done for libstand32 in rS293040.

(That is, I believe they've just unintentionally diverged over time, and that we can just .include lib/libstand/Makefile. One thing I'm not quite sure about is the use of bsd.own.mk / src.opts.mk. @grehan, can you comment on these items?)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 11937.Jan 5 2016, 2:28 AM
emaste retitled this revision from to Reduce libstand Makefile duplication.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: jhb, grehan.
emaste added a subscriber: grehan.
imp accepted this revision.Jan 5 2016, 2:31 AM
imp added a reviewer: imp.
imp added a subscriber: imp.

I love the red to green ratio here :)

My acceptance is provisional on it still working. We have some overrides, I think, and so long as they still override, I think we're good.

This revision is now accepted and ready to land.Jan 5 2016, 2:31 AM
grehan edited edge metadata.Jan 5 2016, 6:50 AM

The bsd.own.mk is a result of copying the libstand Makefile when userboot was first implemented by dfr, and subsequent catchups to changes in the mk templates. I can't think of any reason why it should continue to be there.

jhb edited edge metadata.Jan 6 2016, 6:00 PM

I'm happy so long as it works.

allanjude accepted this revision.Jan 8 2016, 4:48 AM
allanjude added a reviewer: allanjude.
allanjude added a subscriber: allanjude.

Tested and works fine with bhyve

emaste planned changes to this revision.Jan 8 2016, 4:53 AM

This needs to have the change in rS293341 incorporated.

Closed by commit rS293435: Reduce libstand Makefile duplication (authored by emaste). · Explain WhyJan 8 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
userboot/
libstand/
134 lines

Diff 12056

View Options

head/sys/boot/userboot/libstand/Makefile

Loading...