Paths

Table of Contentst

comsat: move uid/gid setting earlier
ClosedPublic
Actions

Authored by emaste on Dec 2 2024, 5:48 PM.

Tags

None

Referenced Files

	F156440923: D47869.id147370.diff
	Wed, May 13, 5:31 PM

	F156440905: D47869.id147373.diff
	Wed, May 13, 5:30 PM

	F156440879: D47869.id147368.diff
	Wed, May 13, 5:30 PM

	F156438332: D47869.diff
	Wed, May 13, 5:11 PM

	Unknown Object (File)
	Tue, Apr 21, 12:47 PM

	Unknown Object (File)
	Mon, Apr 20, 4:42 PM

	Unknown Object (File)
	Sat, Apr 18, 1:47 PM

	Unknown Object (File)
	Sat, Apr 18, 10:01 AM

View All Files

Subscribers

imp

Details

Reviewers

jlduran

Commits

rG30bcbf8a2fef: comsat: move uid/gid setting earlier
rG91629228e3df: comsat: move uid/gid setting earlier

Summary

It's good to reduce privilege as early as possible.

Suggested by:   jlduran
Obtained from:  NetBSD
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 2 2024, 5:48 PM

emaste created this revision.

jlduran added inline comments.Dec 2 2024, 6:38 PM

libexec/comsat/comsat.c
60	To ensure `hostname` is null-terminated (can be submitted separately, if considered appropriate).
62
148
185
186
200
216

Sorry about that, actually test building the change :)

jlduran accepted this revision.Dec 2 2024, 7:42 PM

This revision is now accepted and ready to land.Dec 2 2024, 7:42 PM

Closed by commit rG91629228e3df: comsat: move uid/gid setting earlier (authored by emaste). · Explain WhyDec 2 2024, 7:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG91629228e3df: comsat: move uid/gid setting earlier.

Herald added a subscriber: imp. · View Herald TranscriptDec 2 2024, 7:57 PM

emaste added a commit: rG30bcbf8a2fef: comsat: move uid/gid setting earlier.Dec 4 2024, 6:39 PM

des mentioned this in rG1501ecebf5af: comsat: Improve use of setuid().Aug 5 2025, 11:52 AM

Revision Contents
Changeset List

Path

Size

libexec/

comsat/

comsat.c

23 lines

Diff 147373

View Options

comsat: move uid/gid setting earlierClosedPublicActions