Page MenuHomeFreeBSD
Differential D47869

comsat: move uid/gid setting earlier
ClosedPublic
Actions

Authored by emaste on Dec 2 2024, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 11:31 AM
Unknown Object (File)
Wed, Aug 12, 10:04 AM
Unknown Object (File)
Tue, Aug 11, 5:40 PM
Unknown Object (File)
Tue, Aug 11, 1:54 AM
Unknown Object (File)
Mon, Aug 10, 10:37 PM
Unknown Object (File)
Mon, Aug 10, 8:22 AM
Unknown Object (File)
Fri, Aug 7, 5:17 PM
Unknown Object (File)
Fri, Aug 7, 9:34 AM
View All Files
Subscribers
imp

Details

Reviewers
jlduran
Commits
rG30bcbf8a2fef: comsat: move uid/gid setting earlier
rG91629228e3df: comsat: move uid/gid setting earlier
Summary
It's good to reduce privilege as early as possible.

Suggested by:   jlduran
Obtained from:  NetBSD
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 2 2024, 5:48 PM
emaste created this revision.
jlduran added inline comments.Dec 2 2024, 6:38 PM
libexec/comsat/comsat.c
60

To ensure hostname is null-terminated (can be submitted separately, if considered appropriate).

62
148
185
186
200
216
emaste updated this revision to Diff 147370.Dec 2 2024, 7:17 PM
emaste marked 5 inline comments as done.

Sorry about that, actually test building the change :)

jlduran accepted this revision.Dec 2 2024, 7:42 PM
This revision is now accepted and ready to land.Dec 2 2024, 7:42 PM
Closed by commit rG91629228e3df: comsat: move uid/gid setting earlier (authored by emaste). · Explain WhyDec 2 2024, 7:57 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG91629228e3df: comsat: move uid/gid setting earlier.
Herald added a subscriber: imp. · View Herald TranscriptDec 2 2024, 7:57 PM
emaste added a commit: rG30bcbf8a2fef: comsat: move uid/gid setting earlier.Dec 4 2024, 6:39 PM
des mentioned this in rG1501ecebf5af: comsat: Improve use of setuid().Aug 5 2025, 11:52 AM

Revision Contents
Changeset List

PathSize
libexec/
comsat/
23 lines

Diff 147373

View Options

libexec/comsat/comsat.c

Loading...