Page MenuHomeFreeBSD

hwreset: fix clk_id type
AcceptedPublic

Authored by br on Sat, Nov 30, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 8:18 AM
Unknown Object (File)
Tue, Dec 3, 4:51 AM
Unknown Object (File)
Sun, Dec 1, 4:49 PM
Subscribers
None

Details

Reviewers
mhorne
jrtc27
Summary

The ID is passed as intptr_t everywhere except this place.
This is needed for Premier P550 that features 2 reset cells (unusually)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Sat, Nov 30, 8:49 PM
br created this revision.
br added a child revision: D47853: eswin reset driver.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

I agree, it should be converted to a long.

This commit is still correct as-is.

This revision is now accepted and ready to land.Mon, Dec 2, 5:09 PM