Page MenuHomeFreeBSD

hwreset: fix clk_id type
AcceptedPublic

Authored by br on Nov 30 2024, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 2:02 AM
Unknown Object (File)
Sep 12 2025, 9:35 PM
Unknown Object (File)
Sep 12 2025, 1:18 AM
Unknown Object (File)
Sep 10 2025, 9:04 PM
Unknown Object (File)
Sep 7 2025, 5:22 PM
Unknown Object (File)
Aug 31 2025, 6:07 PM
Unknown Object (File)
Aug 30 2025, 11:34 PM
Unknown Object (File)
Aug 15 2025, 12:11 AM
Subscribers
None

Details

Reviewers
mhorne
jrtc27
Summary

The ID is passed as intptr_t everywhere except this place.
This is needed for Premier P550 that features 2 reset cells (unusually)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Nov 30 2024, 8:49 PM
br created this revision.
br added a child revision: D47853: eswin reset driver.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

I agree, it should be converted to a long.

This commit is still correct as-is.

This revision is now accepted and ready to land.Dec 2 2024, 5:09 PM