Page MenuHomeFreeBSD

hwreset: fix clk_id type
AcceptedPublic

Authored by br on Nov 30 2024, 8:49 PM.
Tags
None
Referenced Files
F111338433: D47854.id.diff
Sun, Mar 2, 1:45 PM
Unknown Object (File)
Jan 15 2025, 6:08 AM
Unknown Object (File)
Jan 15 2025, 12:05 AM
Unknown Object (File)
Jan 12 2025, 12:24 AM
Unknown Object (File)
Jan 6 2025, 11:55 AM
Unknown Object (File)
Jan 6 2025, 8:56 AM
Unknown Object (File)
Jan 6 2025, 3:05 AM
Unknown Object (File)
Dec 13 2024, 12:34 PM
Subscribers
None

Details

Reviewers
mhorne
jrtc27
Summary

The ID is passed as intptr_t everywhere except this place.
This is needed for Premier P550 that features 2 reset cells (unusually)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Nov 30 2024, 8:49 PM
br created this revision.
br added a child revision: D47853: eswin reset driver.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

I agree, it should be converted to a long.

This commit is still correct as-is.

This revision is now accepted and ready to land.Dec 2 2024, 5:09 PM