Page MenuHomeFreeBSD
Differential D47589

getentropy: note that it is nearly POSIX 2024
ClosedPublic
Actions

Authored by emaste on Nov 15 2024, 2:46 PM.
Tags
None
Referenced Files
F118875565: D47589.diff
Mon, Jun 2, 8:28 PM
Unknown Object (File)
Fri, May 30, 5:12 AM
Unknown Object (File)
Thu, May 29, 7:08 AM
Unknown Object (File)
Tue, May 13, 4:48 PM
Unknown Object (File)
Wed, May 7, 12:13 AM
Unknown Object (File)
Apr 21 2025, 5:04 PM
Unknown Object (File)
Apr 21 2025, 4:57 PM
Unknown Object (File)
Apr 19 2025, 8:27 AM
View All 39 Files
Subscribers
ziaee

Details

Reviewers
brooks
imp
Commits
rG93a321b60750: libc: Note that getentropy is nearly POSIX 2024
rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024
Summary
Our implementation diverges from POSIX 2024 in a couple of ways, as
noted in BUGS.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Nov 15 2024, 2:46 PM
emaste created this revision.
imp added inline comments.Nov 15 2024, 2:51 PM
lib/libc/gen/getentropy.3
86

Does this need a PR?

87

Can you articulate which ones briefly?

emaste added inline comments.Nov 15 2024, 2:56 PM
lib/libc/gen/getentropy.3
86

OK, PR282783

87

At least EIO instead of EINVAL when len exceeds GETENTROPY_MAX but I haven't checked all values that we return and all that are in 2024.

ziaee added a subscriber: ziaee.Nov 15 2024, 7:32 PM
ziaee added inline comments.
lib/libc/gen/getentropy.3
72–73

In vi(1) we say "is close to".

brooks added inline comments.Nov 15 2024, 10:49 PM
lib/libc/gen/getentropy.3
18
emaste updated this revision to Diff 146746.Nov 20 2024, 2:27 PM

typo, mention that it nearly conforms to posix 24

emaste marked 3 inline comments as done.Nov 20 2024, 2:27 PM
emaste added inline comments.Nov 20 2024, 4:24 PM
lib/libc/gen/getentropy.3
87
brooks accepted this revision.Nov 20 2024, 7:24 PM
This revision is now accepted and ready to land.Nov 20 2024, 7:24 PM
Closed by commit rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024 (authored by emaste). · Explain WhyNov 20 2024, 7:32 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024.
emaste added a commit: rG93a321b60750: libc: Note that getentropy is nearly POSIX 2024.Nov 24 2024, 4:47 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
14 lines

Diff 146746

View Options

lib/libc/gen/getentropy.3

Loading...