getentropy: note that it is nearly POSIX 2024
ClosedPublic
Actions

Authored by emaste on Nov 15 2024, 2:46 PM.

Details

Reviewers

brooks
imp

Commits

rG93a321b60750: libc: Note that getentropy is nearly POSIX 2024
rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024

Summary

Our implementation diverges from POSIX 2024 in a couple of ways, as
noted in BUGS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 15 2024, 2:46 PM

emaste created this revision.

imp added inline comments.Nov 15 2024, 2:51 PM

lib/libc/gen/getentropy.3
86	Does this need a PR?
87	Can you articulate which ones briefly?

emaste added inline comments.Nov 15 2024, 2:56 PM

lib/libc/gen/getentropy.3
86	OK, PR282783
87	At least `EIO` instead of `EINVAL` when len exceeds `GETENTROPY_MAX` but I haven't checked all values that we return and all that are in 2024.

ziaee added a subscriber: ziaee.Nov 15 2024, 7:32 PM

ziaee added inline comments.

lib/libc/gen/getentropy.3
72–73	In vi(1) we say "is close to".

brooks added inline comments.Nov 15 2024, 10:49 PM

lib/libc/gen/getentropy.3
18

typo, mention that it nearly conforms to posix 24

emaste marked 3 inline comments as done.Nov 20 2024, 2:27 PM

emaste added inline comments.Nov 20 2024, 4:24 PM

lib/libc/gen/getentropy.3
87

brooks accepted this revision.Nov 20 2024, 7:24 PM

This revision is now accepted and ready to land.Nov 20 2024, 7:24 PM

Closed by commit rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024 (authored by emaste). · Explain WhyNov 20 2024, 7:32 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024.

emaste added a commit: rG93a321b60750: libc: Note that getentropy is nearly POSIX 2024.Nov 24 2024, 4:47 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

getentropy.3

14 lines

Diff 146762

View Options

getentropy: note that it is nearly POSIX 2024ClosedPublicActions