getentropy: note that it is nearly POSIX 2024
ClosedPublic
Actions

Authored by emaste on Fri, Nov 15, 2:46 PM.

Details

Reviewers

brooks
imp

Commits

rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024

Summary

Our implementation diverges from POSIX 2024 in a couple of ways, as
noted in BUGS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, Nov 15, 2:46 PM

emaste created this revision.

imp added inline comments.Fri, Nov 15, 2:51 PM

lib/libc/gen/getentropy.3
86	Does this need a PR?
87	Can you articulate which ones briefly?

emaste added inline comments.Fri, Nov 15, 2:56 PM

lib/libc/gen/getentropy.3
86	OK, PR282783
87	At least `EIO` instead of `EINVAL` when len exceeds `GETENTROPY_MAX` but I haven't checked all values that we return and all that are in 2024.

concussious.bugzilla_runbox.com added a subscriber: concussious.bugzilla_runbox.com.Fri, Nov 15, 7:32 PM

concussious.bugzilla_runbox.com added inline comments.

lib/libc/gen/getentropy.3
72–73	In vi(1) we say "is close to".

brooks added inline comments.Fri, Nov 15, 10:49 PM

lib/libc/gen/getentropy.3
18

typo, mention that it nearly conforms to posix 24

emaste marked 3 inline comments as done.Wed, Nov 20, 2:27 PM

emaste added inline comments.Wed, Nov 20, 4:24 PM

lib/libc/gen/getentropy.3
87

brooks accepted this revision.Wed, Nov 20, 7:24 PM

This revision is now accepted and ready to land.Wed, Nov 20, 7:24 PM

Closed by commit rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024 (authored by emaste). · Explain WhyWed, Nov 20, 7:32 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

getentropy.3

14 lines

Diff 146762

View Options

getentropy: note that it is nearly POSIX 2024ClosedPublicActions