Page MenuHomeFreeBSD

Fix fstat()/lseek() use in MDXFileChunk()
ClosedPublic

Authored by jtl on Jan 1 2016, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 8:53 AM
Unknown Object (File)
Fri, Apr 12, 8:25 AM
Unknown Object (File)
Mar 17 2024, 3:24 AM
Unknown Object (File)
Mar 11 2024, 6:46 AM
Unknown Object (File)
Dec 20 2023, 2:54 AM
Unknown Object (File)
Aug 10 2023, 4:21 PM
Unknown Object (File)
Jun 27 2023, 9:00 AM
Unknown Object (File)
Jun 16 2023, 6:04 PM
Subscribers

Details

Reviewers
allanjude
delphij
Group Reviewers
secteam
Summary

As I understand it, @bde voiced three concerns:

  1. Improper use of fstat()/lseek().
  2. Improper documentation of the return value for the function.
  3. Speed due to I/O buffer sizes.

This addresses concern #1.

Test Plan

make && make test

Created a md and was able to use md5 on it:

# mdconfig -a -t swap -s 64m
md0
# env LD_PRELOAD=/usr/obj/usr/src/lib/libmd/libmd.so md5 /dev/md0
MD5 (/dev/md0) = 462be07247e06c953b885b168d1753a1
# sh -c 'for i in /dev/md0; do echo -n "$i: "; md5 <$i; done'
/dev/md0: 462be07247e06c953b885b168d1753a1

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2014
Build 2022: arc lint + arc unit

Event Timeline

jtl retitled this revision from to Fix fstat()/lseek() use in MDXFileChunk().
jtl updated this object.
jtl edited the test plan for this revision. (Show Details)
jtl added reviewers: secteam, allanjude.

Updating with changes based on review by bde@.

I believe he now has accepted these changes. I plan to commit them soon unless I hear further feedback.

allanjude edited edge metadata.

Seems reasonable to me

This revision is now accepted and ready to land.Jan 9 2016, 5:14 PM
delphij added a reviewer: delphij.
delphij added a subscriber: delphij.

Looks good to me.