As I understand it, @bde voiced three concerns:
- Improper use of fstat()/lseek().
- Improper documentation of the return value for the function.
- Speed due to I/O buffer sizes.
This addresses concern #1.
Differential D4748
Fix fstat()/lseek() use in MDXFileChunk() jtl on Jan 1 2016, 1:50 AM. Authored by Tags None Referenced Files
Details As I understand it, @bde voiced three concerns:
This addresses concern #1. make && make test Created a md and was able to use md5 on it: # mdconfig -a -t swap -s 64m md0 # env LD_PRELOAD=/usr/obj/usr/src/lib/libmd/libmd.so md5 /dev/md0 MD5 (/dev/md0) = 462be07247e06c953b885b168d1753a1 # sh -c 'for i in /dev/md0; do echo -n "$i: "; md5 <$i; done' /dev/md0: 462be07247e06c953b885b168d1753a1
Diff Detail
Event TimelineComment Actions Updating with changes based on review by bde@. I believe he now has accepted these changes. I plan to commit them soon unless I hear further feedback. |