Differential D4727

When checking inp_ip_minttl, don't check IPv4 header for IPv6 packets
ClosedPublic
Actions

Authored by jtl on Dec 29 2015, 5:23 PM.

Details

Reviewers

Group Reviewers

transport

Commits

rS292881: When checking the inp_ip_minttl restriction for IPv6 packets, don't check

Summary

If (inp->inp_ip_minttl != 0), conformant IPv6 packets would cause the
code to check the IPv4 header's TTL. Because the variable that stores
the IPv4 header is initialized to NULL in the IPv6 case, this causes
a NULL pointer dereference.

CID: 1017920

Test Plan

Compile

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl updated this revision to Diff 11764.Dec 29 2015, 5:23 PM

jtl retitled this revision from to When checking inp_ip_minttl, don't check IPv4 header for IPv6 packets.

jtl updated this object.

jtl edited the test plan for this revision. (Show Details)

jtl added a reviewer: transport.

Herald edited edge metadata. · View Herald TranscriptDec 29 2015, 5:23 PM

Herald added a subscriber: imp. · View Herald Transcript

bz accepted this revision.Dec 29 2015, 5:52 PM

bz added a reviewer: bz.

This revision is now accepted and ready to land.Dec 29 2015, 5:52 PM

Closed by commit rS292881: When checking the inp_ip_minttl restriction for IPv6 packets, don't check (authored by jtl). · Explain WhyDec 29 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_input.c

7 lines

Diff 11767

View Options

head/sys/netinet/tcp_input.c

When checking inp_ip_minttl, don't check IPv4 header for IPv6 packetsClosedPublicActions