[fdp]New FDP Primer workflow chapter and related updates

[pauamma_gundo.com]

I'll look at the screenshots and diagrams later. I don't want to defer this installment any further.

documentation/content/en/books/fdp-primer/workflow/_index.adoc

83

Spurious space.

98

I'd make that a link to the "working copy" chapter.

107

110

111

Somewhere in this paragraph, I'd mention that if you specify docs as a group reviewer, members of docs on Phabricator (which should be most Doc Team members if not all) get an email notice of the review.

documentation/content/en/books/fdp-primer/working-copy/_index.adoc

57

What is your rationale for this change?

140–141

141

Is it worth linking to https://sethrobertson.github.io/GitFixUm/fixup.html here or in the resources section?

145–154

IIRC, after using "git add", you need to use "git diff --staged". Plain "git diff" will return an empty diff, confusing everyone involved. Or move the "git add" to just before "git commit" in the workflow that needs a commit.

149

178

Since you're touching this line: this is no longer needed. Instead, the patch contributor should check the "attachment is patch" box in the web interface when uploading the patch.

199

This looks out of place here. Shouldn't it be after the last line of this change, starting with

The differential is immediately available for inspection

?

210

215

277

Not necessarily the reviewer - it can be the submitter themselves.

284

341

345

358

384

[jpb_jimby.name]

These updates include some extra content in 4.7 "Making a Diff to Submit to Bugzilla".

documentation/content/en/books/fdp-primer/working-copy/_index.adoc

57

The link to https://git-scm.com takes the reader off the FreeBSD ecosystem to the git homepage which does not give the reader access to much useful information. The link to the git man page provides immediate useful information that is FreeBSD specific.

The link package:devel/git[] takes the reader to the useless index page for the git port which has no information about how to install the port or package.

I've opted for the revised text which keeps the reader focused on the doc tool set.

141

Both places.

145–154

This is existing content. I was trying to apply just the minimum changes.

I've added "git diff --staged" text as you suggested.

[jpb_jimby.name]

[fdp]New FDP Primer workflow chapter and related updates

[jpb_jimby.name]

[fdp]New FDP Primer workflow chapter and related updates

Updated hrefs, minor typo and style changes.

[carlavilla]

Thank you so much for your changes.
I'm gonna make a review and if everything it's ok I'll make the commit :)