Page MenuHomeFreeBSD

cdefs: Use __has_feature to gate the definition of __nosanitize*
ClosedPublic

Authored by markj on Oct 19 2024, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 3:35 PM
Unknown Object (File)
Fri, Nov 29, 11:42 AM
Unknown Object (File)
Fri, Nov 29, 11:41 AM
Unknown Object (File)
Fri, Nov 29, 11:41 AM
Unknown Object (File)
Tue, Nov 26, 1:58 PM
Unknown Object (File)
Mon, Nov 25, 4:06 PM
Unknown Object (File)
Mon, Nov 25, 4:06 PM
Unknown Object (File)
Mon, Nov 25, 4:06 PM
Subscribers

Details

Summary

clang 12 does not implement the coverage sanitizer, and the build fails
when attribute((no_sanitize("coverage"))) is used.

Try to work around the problem by giving __nosanitize* a non-trivial
definition only when the corresponding sanitizer is actually enabled in
the build.

Tested by reading disassembly of pmap_update_strided() and pmap_enter()
in a kernel compiled with "options COVERAGE", and similar sanity checks
for the other sanitizers. I also test-booted KASAN and KMSAN kernels in
amd64 bhyve.

Suggested by: jrtc27
Fixes: a78bacf3b0ec ("cdefs: Add __nosanitizecoverage")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Oct 19 2024, 2:30 PM

Why test for clang? Is gcc broken for sanitizers?

This revision is now accepted and ready to land.Oct 19 2024, 2:47 PM
In D47193#1076016, @imp wrote:

Why test for clang? Is gcc broken for sanitizers?

See commit 4c235c0083837. I've never tested gcc+kernel sanitizers and I doubt they will just work (though hopefully it wouldn't require a lot of effort).