Page MenuHomeFreeBSD

net/yate: Fix OpenSSL and SQLite dependencies
ClosedPublic

Authored by brnrd on Dec 25 2015, 2:00 PM.
Tags
None
Referenced Files
F125003410: D4706.id.diff
Sat, Aug 2, 6:56 AM
Unknown Object (File)
Sat, Jul 26, 12:38 PM
Unknown Object (File)
Fri, Jul 25, 5:31 PM
Unknown Object (File)
Tue, Jul 22, 8:21 AM
Unknown Object (File)
Tue, Jul 22, 8:20 AM
Unknown Object (File)
Tue, Jul 22, 8:08 AM
Unknown Object (File)
Tue, Jul 22, 7:38 AM
Unknown Object (File)
Thu, Jul 10, 10:24 PM
Subscribers
None

Details

Summary

Proposed commit log:

net/yate: Fix OpenSSL and SQLite dependencies

  - Convert to OPTIONS helpers
  - Order options alphabetically
  - Add missing OpenSSL dependency
  - Use base OpenSSL path from bsd.openssl.mk
  - Add missing SQLite option and dependency

PR:		205170
Reviewed_by:	koobs (mentor), feld (mentor), miwi
Approved by:	<name> (mentor)
Differential_Revision:	https://reviews.freebsd.org/D????
Test Plan
  • portlint -AC (clean)
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1833
Build 1840: arc lint + arc unit

Event Timeline

brnrd retitled this revision from to net/yate: Fix OpenSSL and SQLite dependencies.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: koobs, feld, miwi.
koobs requested changes to this revision.Dec 25 2015, 2:49 PM
koobs updated this object.
koobs edited edge metadata.
koobs added inline comments.
net/yate/Makefile
95

I don't like that this doesn't explicitly strip only it's own libraries. This could potentially match another packages files.

I'd much prefer libyate*.so*

This revision now requires changes to proceed.Dec 25 2015, 2:49 PM
brnrd edited edge metadata.

Make .so files to strip more specific

koobs edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.