Page MenuHomeFreeBSD

net/yate: Fix OpenSSL and SQLite dependencies
ClosedPublic

Authored by brnrd on Dec 25 2015, 2:00 PM.

Details

Summary

Proposed commit log:

net/yate: Fix OpenSSL and SQLite dependencies

  - Convert to OPTIONS helpers
  - Order options alphabetically
  - Add missing OpenSSL dependency
  - Use base OpenSSL path from bsd.openssl.mk
  - Add missing SQLite option and dependency

PR:		205170
Reviewed_by:	koobs (mentor), feld (mentor), miwi
Approved by:	<name> (mentor)
Differential_Revision:	https://reviews.freebsd.org/D????
Test Plan
  • portlint -AC (clean)
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brnrd retitled this revision from to net/yate: Fix OpenSSL and SQLite dependencies.Dec 25 2015, 2:00 PM
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: koobs, feld, miwi.
brnrd updated this revision to Diff 11675.
koobs updated this object.Dec 25 2015, 2:49 PM
koobs edited edge metadata.
koobs requested changes to this revision.
koobs added inline comments.
net/yate/Makefile
95 ↗(On Diff #11675)

I don't like that this doesn't explicitly strip only it's own libraries. This could potentially match another packages files.

I'd much prefer libyate*.so*

This revision now requires changes to proceed.Dec 25 2015, 2:49 PM
brnrd edited edge metadata.Dec 25 2015, 4:51 PM
brnrd updated this revision to Diff 11687.

Make .so files to strip more specific

koobs edited edge metadata.Dec 25 2015, 5:05 PM
koobs accepted this revision.
This revision is now accepted and ready to land.Dec 25 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.