Page MenuHomeFreeBSD

break(2): allow on aarch64 and riscv
AcceptedPublic

Authored by brooks on Oct 4 2024, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 4:26 AM
Unknown Object (File)
Nov 22 2024, 4:47 PM
Unknown Object (File)
Nov 16 2024, 9:17 AM
Unknown Object (File)
Oct 26 2024, 6:03 PM
Unknown Object (File)
Oct 19 2024, 5:31 AM
Unknown Object (File)
Oct 8 2024, 4:05 PM
Unknown Object (File)
Oct 8 2024, 3:18 AM
Unknown Object (File)
Oct 5 2024, 9:27 AM
Subscribers

Details

Reviewers
kib
markj
Summary

Now that the majority of upstream software using sbrk() has been fixed
and there are no default symbols exported from libc, go ahead and
restore the undocumented break system call.

While this is arguably a regression, we've gotten most of the benefit of
not having sbrk and we're stuck with the core implementation on aarch64
for 32-bit support and both for linux emulation (technically not riscv
today, but we'll probably want linux emulation eventually.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60138
Build 57022: arc lint + arc unit

Event Timeline

This is missing some pieces from D42853, namely a change to enable sbrk tests on riscv and arm64, and changes to the libc symbol list.

What is libsbrk? I haven't seen that before.

This is missing some pieces from D42853, namely a change to enable sbrk tests on riscv and arm64, and changes to the libc symbol list.

Oops, will add.

What is libsbrk? I haven't seen that before.

See D43002. I reordered this commit in my branch and didn't update the message.

This revision is now accepted and ready to land.Oct 5 2024, 4:29 AM
This revision now requires review to proceed.Oct 21 2024, 11:54 PM

This is missing some pieces from D42853, namely a change to enable sbrk tests on riscv and arm64, and changes to the libc symbol list.

I enabled the tests, but don't need to do the symbol maps as prior commits have removed the entries entirely.

This revision is now accepted and ready to land.Oct 23 2024, 1:27 PM