Page MenuHomeFreeBSD

loader: Fix 0 vs 1 confusion for column numbers
ClosedPublic

Authored by imp on Sep 24 2024, 5:16 PM.
Tags
None
Referenced Files
F144445251: D46777.id143690.diff
Sun, Feb 8, 11:43 AM
Unknown Object (File)
Sat, Feb 7, 4:45 PM
Unknown Object (File)
Fri, Jan 30, 7:06 PM
Unknown Object (File)
Dec 22 2025, 4:35 PM
Unknown Object (File)
Dec 19 2025, 10:19 AM
Unknown Object (File)
Dec 1 2025, 9:34 AM
Unknown Object (File)
Dec 1 2025, 9:29 AM
Unknown Object (File)
Nov 30 2025, 7:16 AM
Subscribers

Details

Summary

In two places we use '0' for a column number. However, the upper left
hand corner of the screen is 1, 1. Fix those two confusions. Also, fix
a comment that flipped the coordinates in a comment (I'm used to the
vt100 convention where it's row, column (eg y, x)) and didn't notice
the rest of the code uses x, y.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable