Page MenuHomeFreeBSD
Differential D46771

loader: Use printc instead of print to fit in 24,80
ClosedPublic
Actions

Authored by imp on Sep 24 2024, 3:02 PM.
Tags
None
Referenced Files
F133102461: D46771.diff
Thu, Oct 23, 12:11 AM
F133081303: D46771.id143670.diff
Wed, Oct 22, 7:30 PM
Unknown Object (File)
Mon, Oct 20, 3:22 AM
Unknown Object (File)
Fri, Oct 17, 7:55 AM
Unknown Object (File)
Fri, Oct 10, 6:56 PM
Unknown Object (File)
Thu, Sep 25, 2:55 AM
Unknown Object (File)
Sep 13 2025, 4:19 PM
Unknown Object (File)
Sep 13 2025, 3:16 AM
View All 71 Files
Subscribers
dab

Details

Reviewers
manu
kevans
Commits
rG940984f4c1c6: loader: Use printc instead of print to fit in 24,80
rGbf0b82f8292d: loader: Use printc instead of print to fit in 24,80
rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80
Summary

print automatically adds a newline, while printc does not. Use printc in
preference to print for managing the autoboot message. This means we can
use line 24 safely on a 24x80 terminal, restoring some functionality that
was lost in 101afbc6ee2f0

Fixes: 101afbc6ee2f0
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59580
Build 56467: arc lint + arc unit

Event Timeline

imp created this revision.Sep 24 2024, 3:02 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 24 2024, 3:02 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Sep 24 2024, 3:02 PM
Harbormaster completed remote builds in B59580: Diff 143670.Sep 24 2024, 3:02 PM
imp added a reviewer: kevans.Sep 24 2024, 3:02 PM
kevans added inline comments.Sep 24 2024, 3:08 PM
stand/lua/menu.lua
533

Move thec comment to the line above it, please, and this otherwise LGTM

imp updated this revision to Diff 143676.Sep 24 2024, 4:20 PM

Update comments: (1) like kyle suggested and (2) reword the awkard comment about
a common (enough?) VT100 emulator bug that's easily avoided.

Harbormaster completed remote builds in B59581: Diff 143676.Sep 24 2024, 4:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2024, 4:57 PM
Closed by commit rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80 (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80.
imp added a commit: rGbf0b82f8292d: loader: Use printc instead of print to fit in 24,80.Dec 28 2024, 6:55 PM
imp added a commit: rG940984f4c1c6: loader: Use printc instead of print to fit in 24,80.Dec 28 2024, 6:58 PM

Revision Contents
Changeset List

PathSize
stand/
lua/
8 lines

Diff 143670

View Options

stand/lua/menu.lua

Loading...