Page MenuHomeFreeBSD

iwmbtfw(4): Add support for 9260/9560 bluetooth adaptors
ClosedPublic

Authored by wulf on Sep 21 2024, 1:57 PM.
Tags
None
Referenced Files
F106177248: D46735.diff
Thu, Dec 26, 4:15 PM
Unknown Object (File)
Sun, Dec 22, 4:04 AM
Unknown Object (File)
Sun, Dec 1, 8:53 AM
Unknown Object (File)
Wed, Nov 27, 6:31 AM
Unknown Object (File)
Tue, Nov 26, 10:30 PM
Unknown Object (File)
Nov 21 2024, 6:22 PM
Unknown Object (File)
Nov 16 2024, 7:56 PM
Unknown Object (File)
Nov 16 2024, 5:57 PM

Details

Summary

Required firmware files are already included in to comms/iwmbt-firmware port

Sponsored by: Future Crew LLC
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59548
Build 56435: arc lint + arc unit

Event Timeline

wulf requested review of this revision.Sep 21 2024, 1:57 PM
usr.sbin/bluetooth/iwmbtfw/iwmbt_hw.c
497

I think we could use less lines here?

506

folding lines

525

no need for block

530

My general feeling is that all these cases want an MPASS check on len? I always want to do that in some wifi driver bits and then upstream it... they are trusting the driver-fw interface too much..

578

That's spelt *data above.

581

Same

587

can we log an unknown type here?

usr.sbin/bluetooth/iwmbtfw/main.c
84

I like this change! :)

257

Is there a need to initialize ret here?

329

Can we make this a switch statement and default with logging? r an else case + logging for the unknown sbe_type? Or are we not expecting any more changes for that old hardware and then simply ignore me.
Ignore; I saw the check further down in main

724

What if it fails?

wulf marked 7 inline comments as done.

Update to react on comments

wulf added inline comments.
usr.sbin/bluetooth/iwmbtfw/iwmbt_hw.c
497

This is iwmbtfw style inherited from ath3kfw(8)

506

ditto

525

done

530

Add an asserts. Disabled by default in Makefile as in userworld they are enabled in release builds

578

Made it consistent

581

ditto

587

Intel says that other types are ignored in comment. I did so.

usr.sbin/bluetooth/iwmbtfw/main.c
257

Build fails with 'variable 'ret' is used uninitialized' after iwmbt_load_ecdsa_header(hdl, &fw); line

724

It says that "Loading DDC file failed" if debug is enabled. Failure is harmless here according to comments in Linux.

bz added inline comments.
usr.sbin/bluetooth/iwmbtfw/main.c
257

make sense; I was thinking with the switch statement it would work.

This revision is now accepted and ready to land.Oct 28 2024, 2:27 AM
This revision was automatically updated to reflect the committed changes.
wulf marked an inline comment as done.