Page MenuHomeFreeBSD

Status/2024Q3/kyua: Add report
ClosedPublic

Authored by igoro on Sep 17 2024, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 7:03 PM
Unknown Object (File)
Tue, Nov 5, 7:32 PM
Unknown Object (File)
Sun, Nov 3, 10:03 AM
Unknown Object (File)
Fri, Oct 25, 12:59 AM
Unknown Object (File)
Thu, Oct 24, 7:38 AM
Unknown Object (File)
Thu, Oct 24, 12:52 AM
Unknown Object (File)
Tue, Oct 22, 8:35 PM
Unknown Object (File)
Tue, Oct 22, 5:40 PM
Subscribers
None

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro requested review of this revision.Sep 17 2024, 6:02 PM

I wonder if it's worth mentioning the work you're doing in the 'skipped' count as well, or if that would just invite bike-shedding.

Rephrase a little. Mention further work.

Thank you for writing this. I included some suggestions, but please feel free to replace them with your own.

website/content/en/status/report-2024-07-2024-09/kyua.adoc
6

I would instead write something like, "The FreeBSD test suite is executed by the kyua utility."

kyua is a tool that lets you glue different test frameworks (e.g., ATF, googletest, TAP, ...) together, giving some unified interface. To me it sounds a bit incorrect to call kyua itself a "framework."

7
8
11
13
14

I would specifically mention VNETs here, since that's the main component that makes this concept useful.

15

Isn't this speedup relative to the amount of parallelism? That is, the speedup from parallelism=2 and parallelism=100 is different.

Thank you for writing this. I included some suggestions, but please feel free to replace them with your own.

Thanks for your help!

website/content/en/status/report-2024-07-2024-09/kyua.adoc
6

I've simply followed the official README, but I think it should not hurt anyone with rewording. I guess, the "framework" term is an eternal dispute :)

15

Thanks, I'm so in the context to forget about this. And a reader is out of the context completely.

Looks good! A couple more nitpicks.

website/content/en/status/report-2024-07-2024-09/kyua.adoc
8

I would go further and point out directly that this lack of parallelism makes the test suite quite slow.

17
igoro marked an inline comment as done.

Emphasize the problem solved

igoro marked 7 inline comments as done.

Fix a typo

igoro added inline comments.
website/content/en/status/report-2024-07-2024-09/kyua.adoc
8

Yes, this is a good idea to highlight that.

Approved with a few small syntax fixes. Thanks!

website/content/en/status/report-2024-07-2024-09/kyua.adoc
8

Please avoid contractions.

17

We have a macro for file names and paths: [.filename].

19
42

Please remove final blank line.

This revision is now accepted and ready to land.Sep 22 2024, 2:27 PM

Thanks for help with the syntax.

This revision was automatically updated to reflect the committed changes.