Page MenuHomeFreeBSD
Differential D46482

rangelocks: stop caching per-thread rl_q_entry
ClosedPublic
Actions

Authored by kib on Aug 29 2024, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 1, 10:29 PM
Unknown Object (File)
Jul 26 2025, 2:21 AM
Unknown Object (File)
Jul 14 2025, 6:44 AM
Unknown Object (File)
Jul 5 2025, 4:03 PM
Unknown Object (File)
Jul 2 2025, 7:03 PM
Unknown Object (File)
Jun 10 2025, 6:02 PM
Unknown Object (File)
Jun 3 2025, 6:50 AM
Unknown Object (File)
May 31 2025, 9:34 PM
View All 75 Files
Subscribers
imp
olce

Details

Reviewers
markj
Commits
rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 29 2024, 8:47 PM
Herald added subscribers: olce, imp. · View Herald TranscriptAug 29 2024, 8:47 PM
kib requested review of this revision.Aug 29 2024, 8:47 PM
markj accepted this revision.Aug 29 2024, 9:07 PM

Seems ok to me, though I still didn't try to benchmark it. But on average it should be cheaper to allocate a new entry than to call smr_synchronize().

This revision is now accepted and ready to land.Aug 29 2024, 9:07 PM
Closed by commit rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry (authored by kib). · Explain WhyAug 29 2024, 9:33 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry.

Revision Contents
Changeset List

PathSize
sys/
kern/
26 lines
2 lines
sys/
2 lines
1 line

Diff 142605

View Options

sys/kern/kern_rangelock.c

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
#ifdef _KERNEL #ifdef _KERNEL
typedef struct { typedef struct {
struct iso_node *inop; struct iso_node *inop;
int fields; /* interesting fields in this analysis */ int fields; /* interesting fields in this analysis */
daddr_t iso_ce_blk; /* block of continuation area */ daddr_t iso_ce_blk; /* block of continuation area */
off_t iso_ce_off; /* offset of continuation area */ off_t iso_ce_off; /* offset of continuation area */
int iso_ce_len; /* length of continuation area */ int iso_ce_len; /* length of continuation area */
struct iso_mnt *imp; /* mount structure */ struct iso_mnt *imp; /* mount structure */
cd_ino_t *inump; /* inode number pointer */ ino_t *inump; /* inode number pointer */
char *outbuf; /* name/symbolic link output area */ char *outbuf; /* name/symbolic link output area */
u_short *outlen; /* length of above */ u_short *outlen; /* length of above */
u_short maxlen; /* maximum length of above */ u_short maxlen; /* maximum length of above */
int cont; /* continuation of above */ int cont; /* continuation of above */
} ISO_RRIP_ANALYZE; } ISO_RRIP_ANALYZE;
struct iso_directory_record; struct iso_directory_record;
int cd9660_rrip_analyze(struct iso_directory_record *isodir, int cd9660_rrip_analyze(struct iso_directory_record *isodir,
struct iso_node *inop, struct iso_mnt *imp); struct iso_node *inop, struct iso_mnt *imp);
int cd9660_rrip_getname(struct iso_directory_record *isodir, int cd9660_rrip_getname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
cd_ino_t *inump, struct iso_mnt *imp); ino_t *inump, struct iso_mnt *imp);
int cd9660_rrip_getsymname(struct iso_directory_record *isodir, int cd9660_rrip_getsymname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
struct iso_mnt *imp); struct iso_mnt *imp);
int cd9660_rrip_offset(struct iso_directory_record *isodir, int cd9660_rrip_offset(struct iso_directory_record *isodir,
struct iso_mnt *imp); struct iso_mnt *imp);
#endif /* _KERNEL */ #endif /* _KERNEL */
#endif /* _ISOFS_CD9660_ISO_RRIP_H_ */ #endif /* _ISOFS_CD9660_ISO_RRIP_H_ */
View Options

sys/kern/kern_thread.c

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
#ifdef _KERNEL #ifdef _KERNEL
typedef struct { typedef struct {
struct iso_node *inop; struct iso_node *inop;
int fields; /* interesting fields in this analysis */ int fields; /* interesting fields in this analysis */
daddr_t iso_ce_blk; /* block of continuation area */ daddr_t iso_ce_blk; /* block of continuation area */
off_t iso_ce_off; /* offset of continuation area */ off_t iso_ce_off; /* offset of continuation area */
int iso_ce_len; /* length of continuation area */ int iso_ce_len; /* length of continuation area */
struct iso_mnt *imp; /* mount structure */ struct iso_mnt *imp; /* mount structure */
cd_ino_t *inump; /* inode number pointer */ ino_t *inump; /* inode number pointer */
char *outbuf; /* name/symbolic link output area */ char *outbuf; /* name/symbolic link output area */
u_short *outlen; /* length of above */ u_short *outlen; /* length of above */
u_short maxlen; /* maximum length of above */ u_short maxlen; /* maximum length of above */
int cont; /* continuation of above */ int cont; /* continuation of above */
} ISO_RRIP_ANALYZE; } ISO_RRIP_ANALYZE;
struct iso_directory_record; struct iso_directory_record;
int cd9660_rrip_analyze(struct iso_directory_record *isodir, int cd9660_rrip_analyze(struct iso_directory_record *isodir,
struct iso_node *inop, struct iso_mnt *imp); struct iso_node *inop, struct iso_mnt *imp);
int cd9660_rrip_getname(struct iso_directory_record *isodir, int cd9660_rrip_getname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
cd_ino_t *inump, struct iso_mnt *imp); ino_t *inump, struct iso_mnt *imp);
int cd9660_rrip_getsymname(struct iso_directory_record *isodir, int cd9660_rrip_getsymname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
struct iso_mnt *imp); struct iso_mnt *imp);
int cd9660_rrip_offset(struct iso_directory_record *isodir, int cd9660_rrip_offset(struct iso_directory_record *isodir,
struct iso_mnt *imp); struct iso_mnt *imp);
#endif /* _KERNEL */ #endif /* _KERNEL */
#endif /* _ISOFS_CD9660_ISO_RRIP_H_ */ #endif /* _ISOFS_CD9660_ISO_RRIP_H_ */
View Options

sys/sys/proc.h

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
#ifdef _KERNEL #ifdef _KERNEL
typedef struct { typedef struct {
struct iso_node *inop; struct iso_node *inop;
int fields; /* interesting fields in this analysis */ int fields; /* interesting fields in this analysis */
daddr_t iso_ce_blk; /* block of continuation area */ daddr_t iso_ce_blk; /* block of continuation area */
off_t iso_ce_off; /* offset of continuation area */ off_t iso_ce_off; /* offset of continuation area */
int iso_ce_len; /* length of continuation area */ int iso_ce_len; /* length of continuation area */
struct iso_mnt *imp; /* mount structure */ struct iso_mnt *imp; /* mount structure */
cd_ino_t *inump; /* inode number pointer */ ino_t *inump; /* inode number pointer */
char *outbuf; /* name/symbolic link output area */ char *outbuf; /* name/symbolic link output area */
u_short *outlen; /* length of above */ u_short *outlen; /* length of above */
u_short maxlen; /* maximum length of above */ u_short maxlen; /* maximum length of above */
int cont; /* continuation of above */ int cont; /* continuation of above */
} ISO_RRIP_ANALYZE; } ISO_RRIP_ANALYZE;
struct iso_directory_record; struct iso_directory_record;
int cd9660_rrip_analyze(struct iso_directory_record *isodir, int cd9660_rrip_analyze(struct iso_directory_record *isodir,
struct iso_node *inop, struct iso_mnt *imp); struct iso_node *inop, struct iso_mnt *imp);
int cd9660_rrip_getname(struct iso_directory_record *isodir, int cd9660_rrip_getname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
cd_ino_t *inump, struct iso_mnt *imp); ino_t *inump, struct iso_mnt *imp);
int cd9660_rrip_getsymname(struct iso_directory_record *isodir, int cd9660_rrip_getsymname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
struct iso_mnt *imp); struct iso_mnt *imp);
int cd9660_rrip_offset(struct iso_directory_record *isodir, int cd9660_rrip_offset(struct iso_directory_record *isodir,
struct iso_mnt *imp); struct iso_mnt *imp);
#endif /* _KERNEL */ #endif /* _KERNEL */
#endif /* _ISOFS_CD9660_ISO_RRIP_H_ */ #endif /* _ISOFS_CD9660_ISO_RRIP_H_ */
View Options

sys/sys/rangelock.h

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
#ifdef _KERNEL #ifdef _KERNEL
typedef struct { typedef struct {
struct iso_node *inop; struct iso_node *inop;
int fields; /* interesting fields in this analysis */ int fields; /* interesting fields in this analysis */
daddr_t iso_ce_blk; /* block of continuation area */ daddr_t iso_ce_blk; /* block of continuation area */
off_t iso_ce_off; /* offset of continuation area */ off_t iso_ce_off; /* offset of continuation area */
int iso_ce_len; /* length of continuation area */ int iso_ce_len; /* length of continuation area */
struct iso_mnt *imp; /* mount structure */ struct iso_mnt *imp; /* mount structure */
cd_ino_t *inump; /* inode number pointer */ ino_t *inump; /* inode number pointer */
char *outbuf; /* name/symbolic link output area */ char *outbuf; /* name/symbolic link output area */
u_short *outlen; /* length of above */ u_short *outlen; /* length of above */
u_short maxlen; /* maximum length of above */ u_short maxlen; /* maximum length of above */
int cont; /* continuation of above */ int cont; /* continuation of above */
} ISO_RRIP_ANALYZE; } ISO_RRIP_ANALYZE;
struct iso_directory_record; struct iso_directory_record;
int cd9660_rrip_analyze(struct iso_directory_record *isodir, int cd9660_rrip_analyze(struct iso_directory_record *isodir,
struct iso_node *inop, struct iso_mnt *imp); struct iso_node *inop, struct iso_mnt *imp);
int cd9660_rrip_getname(struct iso_directory_record *isodir, int cd9660_rrip_getname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
cd_ino_t *inump, struct iso_mnt *imp); ino_t *inump, struct iso_mnt *imp);
int cd9660_rrip_getsymname(struct iso_directory_record *isodir, int cd9660_rrip_getsymname(struct iso_directory_record *isodir,
char *outbuf, u_short *outlen, char *outbuf, u_short *outlen,
struct iso_mnt *imp); struct iso_mnt *imp);
int cd9660_rrip_offset(struct iso_directory_record *isodir, int cd9660_rrip_offset(struct iso_directory_record *isodir,
struct iso_mnt *imp); struct iso_mnt *imp);
#endif /* _KERNEL */ #endif /* _KERNEL */
#endif /* _ISOFS_CD9660_ISO_RRIP_H_ */ #endif /* _ISOFS_CD9660_ISO_RRIP_H_ */