Page MenuHomeFreeBSD
Differential D46482

rangelocks: stop caching per-thread rl_q_entry
ClosedPublic
Actions

Authored by kib on Aug 29 2024, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2025, 2:46 AM
Unknown Object (File)
Feb 11 2025, 4:07 PM
Unknown Object (File)
Feb 6 2025, 11:53 AM
Unknown Object (File)
Jan 30 2025, 10:39 PM
Unknown Object (File)
Jan 29 2025, 5:43 AM
Unknown Object (File)
Jan 18 2025, 3:03 AM
Unknown Object (File)
Dec 22 2024, 8:08 AM
Unknown Object (File)
Dec 20 2024, 5:57 PM
View All 63 Files
Subscribers
imp
olce

Details

Reviewers
markj
Commits
rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 29 2024, 8:47 PM
Herald added subscribers: olce, imp. · View Herald TranscriptAug 29 2024, 8:47 PM
kib requested review of this revision.Aug 29 2024, 8:47 PM
markj accepted this revision.Aug 29 2024, 9:07 PM

Seems ok to me, though I still didn't try to benchmark it. But on average it should be cheaper to allocate a new entry than to call smr_synchronize().

This revision is now accepted and ready to land.Aug 29 2024, 9:07 PM
Closed by commit rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry (authored by kib). · Explain WhyAug 29 2024, 9:33 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG7e49f04c8839: rangelocks: stop caching per-thread rl_q_entry.

Revision Contents
Changeset List

PathSize
sys/
kern/
26 lines
2 lines
sys/
2 lines
1 line

Diff 142605

View Options

sys/kern/kern_rangelock.c

# $FreeBSD$ # $FreeBSD$
PORTNAME= gh PORTNAME= gh
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.6.0 DISTVERSION= 1.6.1
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= lcook@FreeBSD.org MAINTAINER= lcook@FreeBSD.org
COMMENT= GitHub's official command line tool COMMENT= GitHub's official command line tool
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
Show All 16 LinesGH_TUPLE= AlecAivazis:survey:v2.2.7:alecaivazis_survey_v2/vendor/github.com/AlecAivazis/survey/v2 \
danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \ danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \
davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \ davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \
dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \ dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \
enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \ enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \
fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \ fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \
go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \ go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \
golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \ golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \
golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \ golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \
golang:sync:112230192c58:golang_sync/vendor/golang.org/x/sync \
golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \ golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \
golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \ golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \
google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \ google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \
google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \ google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \
hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \ hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \
henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \ henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \
inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \ inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \
kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \ kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines
View Options

sys/kern/kern_thread.c

# $FreeBSD$ # $FreeBSD$
PORTNAME= gh PORTNAME= gh
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.6.0 DISTVERSION= 1.6.1
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= lcook@FreeBSD.org MAINTAINER= lcook@FreeBSD.org
COMMENT= GitHub's official command line tool COMMENT= GitHub's official command line tool
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
Show All 16 LinesGH_TUPLE= AlecAivazis:survey:v2.2.7:alecaivazis_survey_v2/vendor/github.com/AlecAivazis/survey/v2 \
danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \ danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \
davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \ davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \
dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \ dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \
enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \ enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \
fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \ fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \
go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \ go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \
golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \ golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \
golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \ golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \
golang:sync:112230192c58:golang_sync/vendor/golang.org/x/sync \
golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \ golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \
golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \ golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \
google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \ google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \
google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \ google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \
hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \ hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \
henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \ henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \
inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \ inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \
kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \ kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines
View Options

sys/sys/proc.h

# $FreeBSD$ # $FreeBSD$
PORTNAME= gh PORTNAME= gh
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.6.0 DISTVERSION= 1.6.1
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= lcook@FreeBSD.org MAINTAINER= lcook@FreeBSD.org
COMMENT= GitHub's official command line tool COMMENT= GitHub's official command line tool
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
Show All 16 LinesGH_TUPLE= AlecAivazis:survey:v2.2.7:alecaivazis_survey_v2/vendor/github.com/AlecAivazis/survey/v2 \
danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \ danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \
davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \ davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \
dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \ dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \
enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \ enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \
fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \ fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \
go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \ go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \
golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \ golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \
golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \ golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \
golang:sync:112230192c58:golang_sync/vendor/golang.org/x/sync \
golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \ golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \
golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \ golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \
google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \ google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \
google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \ google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \
hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \ hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \
henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \ henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \
inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \ inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \
kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \ kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines
View Options

sys/sys/rangelock.h

# $FreeBSD$ # $FreeBSD$
PORTNAME= gh PORTNAME= gh
DISTVERSIONPREFIX= v DISTVERSIONPREFIX= v
DISTVERSION= 1.6.0 DISTVERSION= 1.6.1
CATEGORIES= devel CATEGORIES= devel
MAINTAINER= lcook@FreeBSD.org MAINTAINER= lcook@FreeBSD.org
COMMENT= GitHub's official command line tool COMMENT= GitHub's official command line tool
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
Show All 16 LinesGH_TUPLE= AlecAivazis:survey:v2.2.7:alecaivazis_survey_v2/vendor/github.com/AlecAivazis/survey/v2 \
danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \ danwakefield:fnmatch:cbb64ac3d964:danwakefield_fnmatch/vendor/github.com/danwakefield/fnmatch \
davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \ davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \
dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \ dlclark:regexp2:v1.2.0:dlclark_regexp2/vendor/github.com/dlclark/regexp2 \
enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \ enescakir:emoji:v1.0.0:enescakir_emoji/vendor/github.com/enescakir/emoji \
fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \ fatih:color:v1.7.0:fatih_color/vendor/github.com/fatih/color \
go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \ go-yaml:yaml:eeeca48fe776:go_yaml_yaml/vendor/gopkg.in/yaml.v3 \
golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \ golang:crypto:9e8e0b390897:golang_crypto/vendor/golang.org/x/crypto \
golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \ golang:net:ab3426394381:golang_net/vendor/golang.org/x/net \
golang:sync:112230192c58:golang_sync/vendor/golang.org/x/sync \
golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \ golang:sys:669c56c373c4:golang_sys/vendor/golang.org/x/sys \
golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \ golang:text:v0.3.4:golang_text/vendor/golang.org/x/text \
google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \ google:go-cmp:v0.5.2:google_go_cmp/vendor/github.com/google/go-cmp \
google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \ google:shlex:e7afc7fbc510:google_shlex/vendor/github.com/google/shlex \
hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \ hashicorp:go-version:v1.2.1:hashicorp_go_version/vendor/github.com/hashicorp/go-version \
henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \ henvic:httpretty:v0.0.6:henvic_httpretty/vendor/github.com/henvic/httpretty \
inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \ inconshreveable:mousetrap:v1.0.0:inconshreveable_mousetrap/vendor/github.com/inconshreveable/mousetrap \
kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \ kballard:go-shellquote:95032a82bc51:kballard_go_shellquote/vendor/github.com/kballard/go-shellquote \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines