sound: Fix SEQ_SYSEX() macro

[christos]

Summary

Correct implementation also found in Linux's soundcard.h:
https://github.com/torvalds/linux/blob/master/include/uapi/linux/soundcard.h#L1178

seq_processevent() interprets event[1] as device number and does not
work properly with current SEQ_SYSEX() implementation.

MFC after: 2 days
Sponsored by: The FreeBSD Foundation
Pull Request: https://github.com/freebsd/freebsd-src/pull/1374

[christos]

Bump.

[markj]

In D46377#1058035, @christos wrote:

Bump.

Isn't this the same as the patch submitted by Ivan on github? https://github.com/freebsd/freebsd-src/pull/1374

If so, and you think the patch is reasonable, you can just approve it and we'll take care of landing it into src with the correct attribution etc..

[christos]

In D46377#1058133, @markj wrote:

In D46377#1058035, @christos wrote:

Bump.

Isn't this the same as the patch submitted by Ivan on github? https://github.com/freebsd/freebsd-src/pull/1374

If so, and you think the patch is reasonable, you can just approve it and we'll take care of landing it into src with the correct attribution etc..

It is (see "Pull request").

[markj]

In D46377#1058137, @christos wrote:

In D46377#1058133, @markj wrote:

In D46377#1058035, @christos wrote:

Bump.

Isn't this the same as the patch submitted by Ivan on github? https://github.com/freebsd/freebsd-src/pull/1374

If so, and you think the patch is reasonable, you can just approve it and we'll take care of landing it into src with the correct attribution etc..

It is (see "Pull request").

Then there's no need to create a phabricator review. It sounds like the commit message should be improved; you can make a suggestion there and ask the submitter to re-push their patch with a better commit log message. If you're happy with the patch, just click "approve".

[christos]

Alright, didn't know we could use just GitHub for this. Thank you. :)