Page MenuHomeFreeBSD

Mk/Uses/samba.mk: Clean up and define SAMBA_LDB_PORT
ClosedPublic

Authored by 0mp on Aug 19 2024, 8:04 PM.
Tags
None
Referenced Files
F105551455: D46322.diff
Tue, Dec 17, 1:55 PM
Unknown Object (File)
Thu, Dec 5, 3:35 AM
Unknown Object (File)
Thu, Nov 28, 9:33 PM
Unknown Object (File)
Nov 16 2024, 6:58 AM
Unknown Object (File)
Oct 29 2024, 1:17 PM
Unknown Object (File)
Oct 22 2024, 5:37 AM
Unknown Object (File)
Oct 9 2024, 6:29 AM
Unknown Object (File)
Oct 3 2024, 12:05 AM

Details

Summary
  • Deprecate the SAMBAPORT, SAMBALIBS, and SAMBAINCLUDES variables and replace them with the more readable and consistent SAMBA_PORT, SAMBA_LIBDIR, and SAMBA_INCLUDEDIR. The new variables follow the conventions of python.mk, ruby.mk, and cargo.mk more and are more future-proof.
  • Rearrange the order of IGNORE checks.
  • Explicitly mention the ports used samba.mk in a searchable manner (i.e., grepping for net/samba419 is going to return samba.mk).
  • Define SAMBA_LDB_PORT, which allows ports to always use the right version of ldb for the Samba selected via SAMBA_DEFAULT.
  • Remove old comments about samba.mk becoming more granular once subpackages are committed. Subpackages will not help samba.mk because Samba's bundled dependencies are built as private libraries and are not usable by external software.

PR: 280773
Sponsored by: Klara, Inc.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested review of this revision.Aug 19 2024, 8:04 PM
0mp created this revision.
This revision is now accepted and ready to land.Aug 21 2024, 4:04 PM