Page MenuHomeFreeBSD

sound: Improve sndstat nvlist feederchain format
ClosedPublic

Authored by christos on Aug 15 2024, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:26 PM
Unknown Object (File)
Thu, Oct 9, 1:42 PM
Unknown Object (File)
Wed, Oct 8, 2:33 AM
Unknown Object (File)
Sat, Oct 4, 11:41 PM
Unknown Object (File)
Sep 10 2025, 11:11 PM
Unknown Object (File)
Aug 9 2025, 1:12 AM
Unknown Object (File)
Jul 12 2025, 3:26 PM
Unknown Object (File)
Jul 12 2025, 11:09 AM
Subscribers

Details

Summary
  • Use snd_afmt2str() to display format conversions in feeder_format, instead of the plain hex value.
  • Simplify feeder_rate contents.
  • Print "ch" (e.g 2.1ch) after matrix values in feeder_matrix.
  • Use snd_afmt2str() instead of a plain hex for the the rest of the feeder classes.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/sndstat.c
555

I think we could omit the hex here.

sys/dev/sound/pcm/sndstat.c
555

I suppose we can use snd_afmt2str() as in feeder_format, otherwise it looks a bit strange in the feeder chain.

christos marked an inline comment as done.

Use snd_aftm2str() instead of plain hex value for the rest of the feeder
classes.

This revision is now accepted and ready to land.Aug 23 2024, 8:53 PM