Page MenuHomeFreeBSD
Differential D46309

sound: Improve sndstat nvlist feederchain format
ClosedPublic
Actions

Authored by christos on Thu, Aug 15, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 3:59 AM
Unknown Object (File)
Mon, Sep 9, 12:56 AM
Unknown Object (File)
Sun, Sep 8, 2:12 AM
Unknown Object (File)
Sat, Sep 7, 12:22 PM
Unknown Object (File)
Fri, Sep 6, 3:59 AM
Unknown Object (File)
Fri, Sep 6, 12:27 AM
Unknown Object (File)
Sat, Aug 24, 1:16 PM
Unknown Object (File)
Wed, Aug 21, 1:30 PM
View All 9 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG8156d8598f59: sound: Improve sndstat nvlist feederchain format
rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format
Summary
  • Use snd_afmt2str() to display format conversions in feeder_format, instead of the plain hex value.
  • Simplify feeder_rate contents.
  • Print "ch" (e.g 2.1ch) after matrix values in feeder_matrix.
  • Use snd_afmt2str() instead of a plain hex for the the rest of the feeder classes.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Thu, Aug 15, 4:12 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Aug 15, 4:12 PM
christos requested review of this revision.Thu, Aug 15, 4:12 PM
Harbormaster completed remote builds in B59038: Diff 142119.Thu, Aug 15, 4:12 PM
christos added inline comments.Thu, Aug 15, 4:13 PM
sys/dev/sound/pcm/sndstat.c
555

I think we could omit the hex here.

dev_submerge.ch added inline comments.Tue, Aug 20, 3:13 PM
sys/dev/sound/pcm/sndstat.c
555

I suppose we can use snd_afmt2str() as in feeder_format, otherwise it looks a bit strange in the feeder chain.

christos edited the summary of this revision. (Show Details)Tue, Aug 20, 3:23 PM
christos updated this revision to Diff 142267.Tue, Aug 20, 3:24 PM
christos marked an inline comment as done.

Use snd_aftm2str() instead of plain hex value for the rest of the feeder
classes.

Harbormaster completed remote builds in B59109: Diff 142267.Tue, Aug 20, 3:24 PM
christos added a comment.Fri, Aug 23, 2:03 PM

Bump.

dev_submerge.ch accepted this revision.Fri, Aug 23, 8:53 PM
This revision is now accepted and ready to land.Fri, Aug 23, 8:53 PM
Closed by commit rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format (authored by christos). · Explain WhySat, Aug 24, 12:09 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format.
christos added a commit: rG8156d8598f59: sound: Improve sndstat nvlist feederchain format.Mon, Aug 26, 1:55 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
18 lines

Diff 142404

View Options

sys/dev/sound/pcm/sndstat.c

Loading...