Differential D46256

grep: Default to -p instead of -S.
ClosedPublic
Actions

Authored by jhb on Aug 9 2024, 6:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 15, 5:23 PM

	Unknown Object (File)
	Sat, Oct 4, 3:48 PM

	Unknown Object (File)
	Sep 18 2025, 8:51 AM

	Unknown Object (File)
	Sep 17 2025, 9:12 PM

	Unknown Object (File)
	Sep 17 2025, 5:07 AM

	Unknown Object (File)
	Sep 11 2025, 11:45 PM

	Unknown Object (File)
	Aug 26 2025, 8:50 PM

	Unknown Object (File)
	Aug 26 2025, 7:55 AM

View All 99 Files

Subscribers

radoslaw.piliszek_gmail.com

Details

Reviewers

Commits

rG35b193572545: grep: Default to -p instead of -S.
rG83f1b98d8227: grep: Default to -p instead of -S.
rGfc12c191c087: grep: Default to -p instead of -S.

Summary

This matches the documented behavior in the manpage as well as the
default behavior on macOS.

PR: 280676
Reported by: Radosław Piliszek <radoslaw.piliszek@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 9 2024, 6:58 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 9 2024, 6:58 PM

jhb requested review of this revision.Aug 9 2024, 6:58 PM

Harbormaster completed remote builds in B58978: Diff 141957.Aug 9 2024, 6:58 PM

jhb added a parent revision: D46255: grep: Fix various bugs in recursive tree handling.Aug 9 2024, 6:58 PM

emaste added a subscriber: emaste.Aug 9 2024, 7:31 PM

radoslaw.piliszek_gmail.com added a subscriber: radoslaw.piliszek_gmail.com.Aug 9 2024, 8:03 PM

It's fine with me, but I note there's a test in contrib/netbsd-tests/usr.bin/grep/t_grep.sh that assumes the default here that will start failing

This revision is now accepted and ready to land.Aug 20 2024, 8:57 PM

Closed by commit rGfc12c191c087: grep: Default to -p instead of -S. (authored by jhb). · Explain WhySep 4 2024, 7:54 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfc12c191c087: grep: Default to -p instead of -S..

jhb added a commit: rG83f1b98d8227: grep: Default to -p instead of -S..Nov 30 2024, 9:24 PM

jhb added a commit: rG35b193572545: grep: Default to -p instead of -S..

Revision Contents
Changeset List

Path

Size

usr.bin/

grep/

2 lines

Diff 142899

usr.bin/grep/grep.c

Loading...