Page MenuHomeFreeBSD

Implemented gh-update
Needs ReviewPublic

Authored by yuri_rawbw.com on Dec 17 2015, 12:04 PM.

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

yuri_rawbw.com retitled this revision from to Implemented gh-update.Dec 17 2015, 12:04 PM
yuri_rawbw.com updated this object.
yuri_rawbw.com edited the test plan for this revision. (Show Details)
yuri_rawbw.com updated this revision to Diff 11376.
yuri_rawbw.com updated this revision to Diff 11382.
mat added a subscriber: mat.Dec 29 2015, 1:42 PM

There's an obvious bug in the "latest" code, it's that you crop the hash to the first 7 bytes.

For example, in the FreeBSD ports git repository, there are 15872 commits that have a short-ref longer than 7 bytes.

I was trying to compile your port for sharelatex for FreeBSD, but i needed this patch to be able to fetch distfiles. I successfully applied it to the base source tree, but i still can't fetch the files. It fails with

_MASTER_SITES_real-time=https://codeload.github.com/sharelatex/real-time-sharelatex/tar.gz/35d9afe?dummy=/: not found

It seems something is appended before the url and causes this fail, coping the url in a browser and trying to request it work just fine. Tried to fix myself, but i can't find any clue where that can come from. Can you fix it?

Sorry for my bad english.

@rodomar705_gmail.com

It looks like you possibly missed this patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205032
This patch (bug#205032) also breaks on 9.X, so you need to use 10.X for now.

9.X compatibility is the only remaining issue before USES=nodejs is finished.

rodomar705_gmail.com added a comment.EditedJan 12 2016, 8:10 PM

Confirmed, that fixed the issue, was able to fetch all the packages, but now i can't apply the patches needed to be able to build it on FreeBSD. Seems that it can't find the correct folder. How many patches (or anything) i need to be able to build sharelatex on 10.2? Thanks for the answers and sorry for the off topic.

rodomar705_gmail.com added a comment.EditedJan 13 2016, 8:00 AM

Sorry, big mistake from me. Was missing a patch from the tree. Now I was being able to fully build and install the package. Still a small issue, when I try to start the service, a lot of

[: =: unexpected operator

Is being printed out to console, still works good, just a cosmetic issue.
However the sharelatex-web service does not start up with

{ [Error: Cannot find module './build/Release/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
{ [Error: Cannot find module './build/default/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
{ [Error: Cannot find module './build/Debug/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
fs.js:857
  return binding.readdir(pathModule._makeLong(path));
                 ^

Error: ENOENT: no such file or directory, scandir '/usr/local/share/node-projects/sharelatex/web/modules'
    at Error (native)

Checking the folder confirm that there is not a modules folder, but a node_modules one, so it is just a typo in some patches or I'm still missing something?

yuri_rawbw.com added a comment.EditedJan 13 2016, 2:24 PM

[: =: unexpected operator

Not sure where this comes from. Are you getting this while running 'service sharelatex start' ?

Error: ENOENT: no such file or directory, scandir '/usr/local/share/node-projects/sharelatex/web/modules'

Sorry, one empty directory got lost with my latest update. You need to run this command for now as a quick workaround:

# mkdir /usr/local/share/node-projects/sharelatex/web/modules

Exactly, while running sharelatex start. And finally after creating that folder (thought that some files was missing, didn't even think that was simply a data directory) and changing the permission of the web folder to the correct user (otherwise the web service simply crash with an error), the web service start up correctly and I was able to use the service. Thanks a ton for the port, and for helping me to being able to use it!

Thanks a ton for the port, and for helping me to being able to use it!

You welcome!

pi added a subscriber: pi.Feb 15 2016, 9:51 AM
0mp added a subscriber: 0mp.Aug 15 2018, 5:09 PM

What's the status of this?

mat added a comment.Aug 16 2018, 2:38 PM
In D4603#355642, @0mp wrote:

What's the status of this?

The only interesting bit was GH_TUPLE, which was integrated, the rest is not really of any interest, it does not make much sense to upgrade all GH_TUPLE entries to their latest revision.

tobik added a subscriber: tobik.Nov 22 2018, 6:47 AM

If it's not directly integrated into the framework, this, or something like it, could still make a useful script for maintainers in Tools/scripts/. Though it would be nice if it could try and offer using the latest tag instead of the latest revision.

mat added a comment.Nov 23 2018, 11:14 AM

Anyone can add things to Tools ;-)