`make installworld' should display the install time
ClosedPublic
Actions

Authored by wosch on Jul 8 2024, 9:30 AM.

Details

Reviewers

imp
emaste
theraven
bapt

Commits

rG9867b4af50c6: Makefile.inc1: show time for `make installworld'
rGe5a0202f9694: Makefile.inc1: show time for `make installworld'

Summary

For years we display the time in seconds how long it takes to run `make buildworld' (see PR 224433).
We should do the same for "installworld" and "installkernel"

e.g.:

Installing everything completed on Sun Jul 7 16:11:37 UTC 2024
Install world completed in 110 seconds, ncpu: 2, make -j2

Test Plan

make -j $(nproc) buildworld
make -j $(nproc) buildkernel installkernel
make -j $(nproc) installworld
make -j $(nproc) packages

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wosch created this revision.Jul 8 2024, 9:30 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 8 2024, 9:30 AM

wosch requested review of this revision.Jul 8 2024, 9:30 AM

imp accepted this revision.Jul 12 2024, 5:59 PM

This revision is now accepted and ready to land.Jul 12 2024, 5:59 PM

Closed by commit rGe5a0202f9694: Makefile.inc1: show time for `make installworld' (authored by wosch). · Explain WhyJul 13 2024, 10:41 AM

This revision was automatically updated to reflect the committed changes.

wosch added a commit: rGe5a0202f9694: Makefile.inc1: show time for `make installworld'.

A report on the pkg-base list suggests that this broke make packages. I am seeing the same breakage, which indeed does look like it's dying in the place modified by this commit:

>>> Installing everything completed on Mon Jul 15 13:31:16 UTC 2024
/tmp/install.wghTiNRH3L/sh: arithmetic expression: expecting primary: "1721050276 - "

And, indeed, reverting this commit locally fixes it. Please can it be reverted and re-landed after testing with make packages?

emaste added a reverting change: rG867873b3980c: Revert "Makefile.inc1: show time for `make installworld'".Jul 15 2024, 1:52 PM

Updated diff with more specific make targets

In D45912#1048212, @theraven wrote:
A report on the pkg-base list suggests that this broke make packages. I am seeing the same breakage, which indeed does look like it's dying in the place modified by this commit:
>>> Installing everything completed on Mon Jul 15 13:31:16 UTC 2024
/tmp/install.wghTiNRH3L/sh: arithmetic expression: expecting primary: "1721050276 - "

@theraven: I'm wondering where I can find a documentation about make packages. I looked at /usr/src/Makefile, /usr/src/README.md and build(7) without success.

wosch added a reviewer: bapt.Mon, Aug 19, 7:22 PM

In D45912#1056437, @wosch wrote:
In D45912#1048212, @theraven wrote:
A report on the pkg-base list suggests that this broke make packages. I am seeing the same breakage, which indeed does look like it's dying in the place modified by this commit:
>>> Installing everything completed on Mon Jul 15 13:31:16 UTC 2024
/tmp/install.wghTiNRH3L/sh: arithmetic expression: expecting primary: "1721050276 - "
@theraven: I'm wondering where I can find a documentation about make packages. I looked at /usr/src/Makefile, /usr/src/README.md and build(7) without success.

There is an entry for that in build.7 now.

If nobody objects I will commit the updated patch next week.

In D45912#1059372, @markj wrote:
In D45912#1056437, @wosch wrote:
In D45912#1048212, @theraven wrote:
A report on the pkg-base list suggests that this broke make packages. I am seeing the same breakage, which indeed does look like it's dying in the place modified by this commit:
>>> Installing everything completed on Mon Jul 15 13:31:16 UTC 2024
/tmp/install.wghTiNRH3L/sh: arithmetic expression: expecting primary: "1721050276 - "
@theraven: I'm wondering where I can find a documentation about make packages. I looked at /usr/src/Makefile, /usr/src/README.md and build(7) without success.
There is an entry for that in build.7 now.