Page MenuHomeFreeBSD

cdefs.h: Remove NO_ANSI_KEYWORDS
ClosedPublic

Authored by imp on Wed, Jul 3, 6:45 PM.
Tags
None
Referenced Files
F87661428: D45861.diff
Sat, Jul 6, 4:12 PM
F87618114: D45861.diff
Fri, Jul 5, 10:13 PM
Unknown Object (File)
Fri, Jul 5, 5:26 PM
Subscribers
None

Details

Summary

Remove very old, deletion of ANSI keywords. Once upon a time, it was
common to want to do this. Then we only did it for non gcc compilers,
then all compilers claimed to be gcc, so we never did it. These days,
it's about useless to keep around since there's no compilers we can test
it with. It's an odd little artifact. Also, the advice in the comment is
wrong: if you define NO_ANSI_KEYWORDS, you can't have progams that use
const, etc as identifiers because they will be deleted. Further, our
header files have the 'bare' ANSI forms of these, so it's a catch 22:
You'd need them deleted for .h files, but not for the code. It's such a
niche case these days that it's best to just remove it.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Wed, Jul 3, 6:45 PM
imp created this revision.
This revision is now accepted and ready to land.Thu, Jul 4, 10:01 AM
This revision was automatically updated to reflect the committed changes.