pf: Fix NULL deref in m_pullup failure case
ClosedPublic
Actions

Authored by igoro on Jul 2 2024, 4:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 9:08 AM

	Unknown Object (File)
	Mon, Oct 28, 10:49 AM

	Unknown Object (File)
	Thu, Oct 17, 7:08 AM

	Unknown Object (File)
	Tue, Oct 15, 8:56 PM

	Unknown Object (File)
	Mon, Oct 14, 5:21 AM

	Unknown Object (File)
	Fri, Oct 11, 6:42 PM

	Unknown Object (File)
	Thu, Oct 10, 3:35 PM

	Unknown Object (File)
	Wed, Oct 9, 1:20 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

kp
glebius

Commits

rG78918c9b271c: pf: Fix NULL deref in m_pullup failure case

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

igoro created this revision.Jul 2 2024, 4:29 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptJul 2 2024, 4:29 PM

igoro requested review of this revision.Jul 2 2024, 4:29 PM

After the main change landing brain starts thinking outside of the box. We could save the m_len before the m_pullup for the sake of a detailed error report, but it's not felt to be very important. Let me know if it is.

I don't think there is any value in saving and printing m_len.

This revision is now accepted and ready to land.Jul 2 2024, 4:38 PM

Closed by commit rG78918c9b271c: pf: Fix NULL deref in m_pullup failure case (authored by igoro, committed by kp). · Explain WhyJul 2 2024, 7:59 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG78918c9b271c: pf: Fix NULL deref in m_pullup failure case.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

3 lines

Diff 140481

View Options

pf: Fix NULL deref in m_pullup failure caseClosedPublicActions