sound: Remove *MINOR from midi/
ClosedPublic
Actions

Authored by christos on Jun 28 2024, 5:38 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGad2934215435: sound: Remove *MINOR from midi/
rG8b9e1b628064: sound: Remove *MINOR from midi/

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Jun 28 2024, 5:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2024, 5:38 PM

christos requested review of this revision.Jun 28 2024, 5:38 PM

Harbormaster completed remote builds in B58389: Diff 140345.Jun 28 2024, 5:38 PM

christos retitled this revision from sound: Remove *MINOR definitions from midi/ to sound: Remove *MINOR from midi/.Jun 28 2024, 5:38 PM

What are the requirements for the unit argument to make_dev()? Should it be unique? We're always producing the same unit number in seq_addunit() now.

sys/dev/sound/midi/midi.c
75–76	Looks like `MIDI_DEV_RAW` is unused now?

In D45772#1044097, @dev_submerge.ch wrote:

What are the requirements for the unit argument to make_dev()? Should it be unique? We're always producing the same unit number in seq_addunit() now.

I cannot find which commit exactly removed the need for the unit argument, but it is generally no longer needed. We could even get rid of the current values we pass to make_dev(). The man page states that instead of unit, the current API uses the si_drv* fields.