Page MenuHomeFreeBSD
Differential D4577

vm_page.h: page busy macro fixups
ClosedPublic
Actions

Authored by rlibby on Dec 15 2015, 8:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 2:19 AM
Unknown Object (File)
Sat, Jan 18, 7:05 AM
Unknown Object (File)
Jan 9 2025, 4:42 PM
Unknown Object (File)
Dec 27 2024, 5:44 AM
Unknown Object (File)
Dec 15 2024, 1:43 AM
Unknown Object (File)
Dec 2 2024, 3:00 AM
Unknown Object (File)
Nov 27 2024, 12:59 PM
Unknown Object (File)
Nov 27 2024, 11:56 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
alc
Commits
rS292383: vm_page.h: page busy macro fixups
Summary

Minor changes to:

  • delete extraneous trailing semicolons from macro definitions, and
  • correct spelling of "busying" in panic messages.

These aren't required changes, but might as well while we're here.

Test Plan

make buildkernel KERNCONF=GENERIC
make buildkernel KERNCONF=GENERIC-NODEBUG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby updated this revision to Diff 11283.Dec 15 2015, 8:58 AM
rlibby retitled this revision from to vm_page.h: page busy macro fixups.
rlibby updated this object.
rlibby edited the test plan for this revision. (Show Details)
rlibby added reviewers: alc, kib.
Herald added a subscriber: imp. · View Herald TranscriptDec 15 2015, 8:58 AM
kib accepted this revision.Dec 15 2015, 3:14 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2015, 3:14 PM
alc added inline comments.Dec 16 2015, 12:26 AM
sys/vm/vm_page.h
517 ↗(On Diff #11283)

Is there a point to these "(void *)" casts? If not, we might as well delete them at the same time as the semi-colon.

rlibby updated this revision to Diff 11337.Dec 16 2015, 2:53 AM
rlibby edited edge metadata.

vm_page.h: alc feedback: also fix up macro arg uses

This revision now requires review to proceed.Dec 16 2015, 2:53 AM
rlibby marked an inline comment as done.Dec 16 2015, 2:57 AM
rlibby added inline comments.
sys/vm/vm_page.h
517 ↗(On Diff #11337)

Not as far as I can tell. I deleted the casts and also added parenthesization around the macro args where it was technically needed.

alc accepted this revision.Dec 16 2015, 3:05 AM
alc edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 3:05 AM
rlibby mentioned this in D4478: vm_fault_hold: use vm_page_replace instead of vm_page_rename.Dec 16 2015, 5:55 PM
Closed by commit rS292383: vm_page.h: page busy macro fixups (authored by cem). · Explain WhyDec 16 2015, 11:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
17 lines

Diff 11360

View Options

head/sys/vm/vm_page.h

Loading...