9pfs: move NULL check immediately after allocation
ClosedPublic
Actions

Authored by emaste on Jun 24 2024, 4:22 PM.

Details

Reviewers

dfr
lattera-gmail.com

Commits

rG0d1dd7c4863a: p9fs: move NULL check immediately after allocation
rG1efd69f933b6: p9fs: move NULL check immediately after allocation

Summary

Reported by: Shawn Webb (HardenedBSD)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jun 24 2024, 4:22 PM

emaste created this revision.

emaste edited reviewers, added: dfr; removed: • d.raith_comcast.net.

emaste added a reviewer: lattera-gmail.com.

LGTM

dfr accepted this revision.Jun 24 2024, 4:24 PM

This revision is now accepted and ready to land.Jun 24 2024, 4:24 PM

Closed by commit rG1efd69f933b6: p9fs: move NULL check immediately after allocation (authored by emaste). · Explain WhyJun 24 2024, 7:37 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG1efd69f933b6: p9fs: move NULL check immediately after allocation.

Herald added a subscriber: imp. · View Herald TranscriptJun 24 2024, 7:37 PM

markj added a subscriber: markj.Jun 24 2024, 8:01 PM

markj added inline comments.

sys/dev/virtio/p9fs/virtio_p9fs.c
334	This can just be an M_WAITOK allocation. We use malloc(M_WAITOK) further below, and device_attach routines are allowed to sleep in general.

arrowd added a commit: rG0d1dd7c4863a: p9fs: move NULL check immediately after allocation.Jul 4 2025, 1:30 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

p9fs/

virtio_p9fs.c

11 lines

Diff 140190

View Options

sys/dev/virtio/p9fs/virtio_p9fs.c

9pfs: move NULL check immediately after allocationClosedPublicActions