Details

Reviewers

kib
emaste
andrew
imp

Commits

rS292407: Import RISC-V machine headers. This is a minimal set required to compile

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br updated this revision to Diff 11241.Dec 14 2015, 6:27 PM

br retitled this revision from to RISC-V includes.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: andrew, emaste.

andrew added inline comments.Dec 14 2015, 7:31 PM

sys/riscv/include/_types.h
97–98 ↗	(On Diff #11241)	These are wrong for an int. arm & arm64 have unsigned `wchar_t` where i tseems to be signed on riscv.
sys/riscv/include/atomic.h
66 ↗	(On Diff #11241)	Should these also have "memory" in the clobber list to stop them from being reordered?
sys/riscv/include/exec.h
40 ↗	(On Diff #11241)	I don't think this is needed, it was for a.out.
sys/riscv/include/float.h
79 ↗	(On Diff #11241)	Needed?
sys/riscv/include/frame.h
49 ↗	(On Diff #11241)	Why 32? I thought x0 only ever contained zero.
sys/riscv/include/intr.h
38 ↗	(On Diff #11241)	Is this needed?
sys/riscv/include/kdb.h
32–33 ↗	(On Diff #11241)	We don't have these on arm64, they might not be needed.
sys/riscv/include/ofw_machdep.h
31–34 ↗	(On Diff #11241)	These have been replaces with `<vm/vm.h>` in the arm64 version.
sys/riscv/include/param.h
85–91 ↗	(On Diff #11241)	Do oyu need these? They look like arm64 things to support multiple page sizes.
107–109 ↗	(On Diff #11241)	Is this needed? I'm not sure if it is on arm64, it was copied from sparc64 but the only other place that uses it is i386.
sys/riscv/include/pcb.h
50 ↗	(On Diff #11241)	Do you need all 32 registers?
sys/riscv/include/pcpu.h
39 ↗	(On Diff #11241)	I think this should be 129
sys/riscv/include/pmc_mdep.h
34 ↗	(On Diff #11241)	Do we need this file if we don't support PMC?
sys/riscv/include/reg.h
41 ↗	(On Diff #11241)	32?
sys/riscv/include/ucontext.h
41 ↗	(On Diff #11241)	32?
47 ↗	(On Diff #11241)	I would suggest you pad this to the expected size of these registers
51 ↗	(On Diff #11241)	Then add it here with a flag field & padding

andrew added a reviewer: imp.Dec 14 2015, 7:31 PM

br updated this revision to Diff 11328.Dec 15 2015, 8:25 PM

br added inline comments.Dec 15 2015, 8:32 PM

sys/riscv/include/pcpu.h
40 ↗	(On Diff #11328)	thanks. how it is calculated ?
sys/riscv/include/pmc_mdep.h
35 ↗	(On Diff #11328)	Yes it is used by kern_pmc.c: sys/conf/files:kern/kern_pmc.c standard

few more defines added

andrew added a reviewer: kib.Dec 17 2015, 10:35 AM

andrew added inline comments.

sys/riscv/include/_types.h
97 ↗	(On Diff #11358)	`__WCHAR_MIN` should be `__INT_MIN`
sys/riscv/include/pcpu.h
41 ↗	(On Diff #11358)	There is a compile time assert: CTASSERT((PAGE_SIZE / sizeof(struct pcpu)) * sizeof(struct pcpu) == PAGE_SIZE); `PCPU_MD_FIELDS` is placed at the end of `struct pcpu`

WCHAR_MIN fixed

kib added inline comments.Dec 17 2015, 3:54 PM

sys/riscv/include/signal.h
40 ↗	(On Diff #11383)	This contradicts the definition of the SIG_ATOMIC_MIN and SIG_ATOMIC_MAX. Amd64 has a bug there, which is hard to fix due to the ABI.

These look fine, modulo my standing comment that we're duplicating *WAY* too much in the
headers. :(

This revision is now accepted and ready to land.Dec 17 2015, 4:00 PM

andrew accepted this revision.Dec 17 2015, 4:33 PM

andrew edited edge metadata.

andrew added inline comments.

sys/riscv/include/minidump.h
37–45 ↗	(On Diff #11383)	I expect this will change, but only becomes an ABI when we use it.
sys/riscv/include/signal.h
40 ↗	(On Diff #11383)	I note arm64 has the same issue.
sys/riscv/include/ucontext.h
53 ↗	(On Diff #11383)	Should these be `__int128_t`?
54–55 ↗	(On Diff #11383)	I assume these are correct.

Closed by commit rS292407: Import RISC-V machine headers. This is a minimal set required to compile (authored by br). · Explain WhyDec 17 2015, 6:44 PM

This revision was automatically updated to reflect the committed changes.

RISC-V includesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11392

head/sys/riscv/include/_align.h

head/sys/riscv/include/_bus.h

head/sys/riscv/include/_inttypes.h

head/sys/riscv/include/_limits.h

head/sys/riscv/include/_stdint.h

head/sys/riscv/include/_types.h

head/sys/riscv/include/asm.h

head/sys/riscv/include/atomic.h

head/sys/riscv/include/bus.h

head/sys/riscv/include/bus_dma.h

head/sys/riscv/include/clock.h

head/sys/riscv/include/counter.h

head/sys/riscv/include/cpu.h

head/sys/riscv/include/cpufunc.h

head/sys/riscv/include/db_machdep.h

head/sys/riscv/include/dump.h

head/sys/riscv/include/elf.h

head/sys/riscv/include/endian.h

head/sys/riscv/include/exec.h

head/sys/riscv/include/float.h

head/sys/riscv/include/floatingpoint.h

head/sys/riscv/include/frame.h

head/sys/riscv/include/ieeefp.h

head/sys/riscv/include/in_cksum.h

head/sys/riscv/include/intr.h

head/sys/riscv/include/kdb.h

head/sys/riscv/include/machdep.h

head/sys/riscv/include/md_var.h

head/sys/riscv/include/memdev.h

head/sys/riscv/include/minidump.h

head/sys/riscv/include/ofw_machdep.h

head/sys/riscv/include/param.h

head/sys/riscv/include/pcb.h

head/sys/riscv/include/pcpu.h

head/sys/riscv/include/pmap.h

head/sys/riscv/include/pmc_mdep.h

head/sys/riscv/include/proc.h

head/sys/riscv/include/profile.h

head/sys/riscv/include/psl.h

head/sys/riscv/include/pte.h

head/sys/riscv/include/ptrace.h

head/sys/riscv/include/reg.h

head/sys/riscv/include/reloc.h

head/sys/riscv/include/resource.h

head/sys/riscv/include/riscvreg.h

head/sys/riscv/include/runq.h

head/sys/riscv/include/setjmp.h

head/sys/riscv/include/sf_buf.h

head/sys/riscv/include/signal.h

head/sys/riscv/include/smp.h

head/sys/riscv/include/stdarg.h

head/sys/riscv/include/sysarch.h

head/sys/riscv/include/trap.h

head/sys/riscv/include/ucontext.h

head/sys/riscv/include/vdso.h

head/sys/riscv/include/vm.h

head/sys/riscv/include/vmparam.h

RISC-V includes
ClosedPublic
Actions

Revision Contents
Changeset List