Page MenuHomeFreeBSD

prepare-commit-msg: add 50 column marker
ClosedPublic

Authored by emaste on Sun, Jun 9, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 8:21 PM
Unknown Object (File)
Wed, Jun 12, 5:18 PM
Unknown Object (File)
Wed, Jun 12, 2:58 AM
Unknown Object (File)
Tue, Jun 11, 4:53 AM
Unknown Object (File)
Mon, Jun 10, 2:59 PM
Unknown Object (File)
Mon, Jun 10, 2:14 AM
Subscribers

Details

Summary

A common convention suggests a 50 column commit subject line (the first
line of the commit message). Add a 50 column marker to the commit
message template

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Sun, Jun 9, 5:27 PM
emaste created this revision.
lwhsu added a subscriber: lwhsu.

How about adding a second comment line says that the 50 is for subject and 72 is for body?

This revision is now accepted and ready to land.Sun, Jun 9, 10:13 PM

How about adding a second comment line says that the 50 is for subject and 72 is for body?

I started writing some extra text but then it seems we should also comment on the blank 2nd line and it got to be a tutorial rather than a quick reference. Perhaps we could add a link to the section in the committer's guide. For now I'll commit this bit.

This revision was automatically updated to reflect the committed changes.