Differential D4553

Don't retry MPI2_IOCSTATUS_SCSI_PROTOCOL_ERROR.
ClosedPublic
Actions

Authored by asomers on Dec 14 2015, 5:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 13, 3:55 AM

	Unknown Object (File)
	Sun, Feb 9, 5:06 PM

	Unknown Object (File)
	Mon, Jan 27, 2:57 PM

	Unknown Object (File)
	Sat, Jan 25, 10:58 PM

	Unknown Object (File)
	Dec 14 2024, 2:54 AM

	Unknown Object (File)
	Dec 5 2024, 1:52 PM

	Unknown Object (File)
	Dec 1 2024, 3:53 PM

	Unknown Object (File)
	Nov 16 2024, 5:25 PM

View All 70 Files

Subscribers

Details

Reviewers

Commits

rS292218: Don't retry SAS commands in response to protocol errors

Summary

sys/dev/mpr/mpr_sas_lsi.c
sys/dev/mps/mps_sas_lsi.c
When mp[rs]sas_get_sata_identify returns
MPI2_IOCSTATUS_SCSI_PROTOCOL_ERROR, don't bother retrying. Protocol
errors aren't likely to be fixed by sleeping.

Without this change, a system that generated may protocol errors due
to signal integrity issues was taking more than an hour to boot, due
to all the retries.

Test Plan

Ran this change in Spectra's lab for two months, including on machines that
generate protocol errors due to signal integrity issues

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 11238.Dec 14 2015, 5:56 PM

asomers retitled this revision from to Don't retry MPI2_IOCSTATUS_SCSI_PROTOCOL_ERROR..

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: slm.

asomers added a subscriber: scottl.

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2015, 5:56 PM

Thanks Alan. Looks good to me.

In D4553#96062, @slm wrote:

Thanks Alan. Looks good to me.

If you're satisfied, can you please check "Accept Revision"?

Didn't see that. Done.

This revision is now accepted and ready to land.Dec 14 2015, 7:34 PM

Closed by commit rS292218: Don't retry SAS commands in response to protocol errors (authored by asomers). · Explain WhyDec 14 2015, 7:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

mpr/

14 lines

mps/

14 lines

Diff 11244

head/sys/dev/mpr/mpr_sas_lsi.c

Loading...

head/sys/dev/mps/mps_sas_lsi.c

Loading...