Page MenuHomeFreeBSD

libc: fix WITHOUT_NIS builds
AbandonedPublic

Authored by emaste on May 24 2024, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 7, 5:55 PM
Unknown Object (File)
Wed, Jun 5, 4:03 AM
Unknown Object (File)
Wed, May 29, 4:03 AM
Unknown Object (File)
May 25 2024, 5:32 PM

Details

Reviewers
imp
Summary
A number of xdr_* functions are not built under WITHOUT_NIS, and must
be conditional in the Symbol.map.

Reported by:    matteo
Reported by:    Michael Dexter's Build Option Survey run

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.
emaste added a subscriber: matteo.

Hrm, we don't pass CFLAGS to symver's use of cpp. I'll give that a try.

imp added a subscriber: imp.

Should do the trick.

This revision is now accepted and ready to land.May 24 2024, 4:38 PM

I see @peterj also reported this in PR279270 and points out there is already a lib/libc/yp/Symbol.map; moving the symbols there is probably better. But I suspect D45346 is still a good idea to support future cases similar to this.

Digging in to this, these should certainly just move to lib/libc/yp/Symbol.map. There are even a couple xdr_ symbols there already.