Page MenuHomeFreeBSD
Differential D45312

sound: Fix minchn, maxchn and fmts in sndstat_get_caps()
ClosedPublic
Actions

Authored by christos on Wed, May 22, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 25, 4:47 PM
Unknown Object (File)
Sat, May 25, 1:49 PM
Unknown Object (File)
Thu, May 23, 4:33 PM
Unknown Object (File)
Thu, May 23, 9:20 AM
Unknown Object (File)
Thu, May 23, 3:54 AM
Unknown Object (File)
Thu, May 23, 3:17 AM
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
brooks
Commits
rG0aa767021c19: sound: Fix minchn, maxchn and fmts in sndstat_get_caps()
rG425a7bc465d4: sound: Fix minchn, maxchn and fmts in sndstat_get_caps()
Summary

The current implementation (incorrectly) passes the channel encoding
value to AFMT_CHANNEL(), which will always return 0, since the channel
number bits are masked out by AFMT_ENCODING().

Also add missing fmts initialization and aggregate encoding formats
into it directly.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Wed, May 22, 11:19 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, May 22, 11:19 PM
christos requested review of this revision.Wed, May 22, 11:19 PM
Harbormaster completed remote builds in B57859: Diff 138953.Wed, May 22, 11:19 PM
dev_submerge.ch added inline comments.Thu, May 23, 12:04 AM
sys/dev/sound/pcm/sndstat.c
354

We should aggregate the encoding formats into *fmts here, it will be left (and used) uninitialized otherwise. And yes, it wasn't initialized in the original code either, let's fix that.

christos retitled this revision from sound: Fix min and max channel counting in sndstat_get_caps() to sound: Fix minchn, maxchn and fmts in sndstat_get_caps().Thu, May 23, 12:11 AM
christos edited the summary of this revision. (Show Details)
christos updated this revision to Diff 138957.Thu, May 23, 12:12 AM
christos marked an inline comment as done.

Address Florian's comment.

Harbormaster completed remote builds in B57863: Diff 138957.Thu, May 23, 12:12 AM
christos edited the summary of this revision. (Show Details)Thu, May 23, 12:12 AM
dev_submerge.ch accepted this revision.Thu, May 23, 12:32 AM
This revision is now accepted and ready to land.Thu, May 23, 12:32 AM
Closed by commit rG425a7bc465d4: sound: Fix minchn, maxchn and fmts in sndstat_get_caps() (authored by christos). · Explain WhyThu, May 23, 12:58 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG425a7bc465d4: sound: Fix minchn, maxchn and fmts in sndstat_get_caps().
christos added a commit: rG0aa767021c19: sound: Fix minchn, maxchn and fmts in sndstat_get_caps().Sat, May 25, 7:32 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
9 lines

Diff 138965

View Options

sys/dev/sound/pcm/sndstat.c

Loading...