Page MenuHomeFreeBSD
Differential D45175

SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information
ClosedPublic
Actions

Authored by kib on Mon, May 13, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 22, 2:41 AM
Unknown Object (File)
Sun, May 19, 3:54 AM
Unknown Object (File)
Sat, May 18, 8:37 PM
Unknown Object (File)
Sat, May 18, 9:47 AM
Unknown Object (File)
Thu, May 16, 7:34 PM
Unknown Object (File)
Thu, May 16, 5:49 PM
Unknown Object (File)
Thu, May 16, 4:43 PM
Unknown Object (File)
Tue, May 14, 6:29 PM
View All 11 Files
Subscribers
imp
olce
rbranco_suse.com

Details

Reviewers
markj
Commits
rG87a156527563: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information
rG53725168e1b6: SysV SHM: move SHMSEG constants to sys/shm.h
Summary

PR: 278949

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Mon, May 13, 11:56 AM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, May 13, 11:56 AM
kib requested review of this revision.Mon, May 13, 11:56 AM
kib edited the summary of this revision. (Show Details)Mon, May 13, 12:07 PM
rbranco_suse.com added a subscriber: rbranco_suse.com.Mon, May 13, 12:15 PM

The native FreeBSD ipcs command also uses these sysctl's.

kib added a comment.Mon, May 13, 12:19 PM
In D45175#1030481, @rbranco_suse.com wrote:

The native FreeBSD ipcs command also uses these sysctl's.

So what is the problem with native?

rbranco_suse.com added a comment.Mon, May 13, 12:26 PM
In D45175#1030482, @kib wrote:
In D45175#1030481, @rbranco_suse.com wrote:

The native FreeBSD ipcs command also uses these sysctl's.

So what is the problem with native?

I couldn't statically compile the 32-bits version to try. But I don't know if it would hit the same error.

markj accepted this revision.Mon, May 13, 1:25 PM
This revision is now accepted and ready to land.Mon, May 13, 1:25 PM
imp added inline comments.Mon, May 13, 2:29 PM
sys/kern/sysv_msg.c
1442 ↗(On Diff #138468)

Is linprocfs only called from linux binaries?

markj added inline comments.Mon, May 13, 2:30 PM
sys/kern/sysv_msg.c
1442 ↗(On Diff #138468)

Oh, right, good point. We'd still want cat(1) etc. to work, so I think this diff isn't the right solution.

imp added a comment.Mon, May 13, 2:32 PM

A 32bit freebsd cat reading /compat/linux/mumble

rbranco_suse.com added a comment.Mon, May 13, 3:18 PM
In D45175#1030482, @kib wrote:
In D45175#1030481, @rbranco_suse.com wrote:

The native FreeBSD ipcs command also uses these sysctl's.

So what is the problem with native?

Forget it. I just tried a 32-bits ipcs on 64-bits and it worked.

kib updated this revision to Diff 138484.Mon, May 13, 5:39 PM
kib retitled this revision from sysvipc: use 32bit structures for kern.ipc reporting sysctls only for native 32bit to SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
kib edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Mon, May 13, 5:39 PM
markj accepted this revision.Tue, May 14, 4:22 PM
markj added inline comments.
sys/kern/sysv_msg.c
1509 ↗(On Diff #138484)

I would just allocate the array with calloc() and not bother with all of this zeroing.

This revision is now accepted and ready to land.Tue, May 14, 4:22 PM
kib added inline comments.Tue, May 14, 10:28 PM
sys/kern/sysv_msg.c
1509 ↗(On Diff #138484)

These members are copied by the assignments like *pmsqk = msgids[i] above. Pre-zeroing the array would not help.

kib updated this revision to Diff 138617.Thu, May 16, 3:34 PM

Move SHMSEG symbols.

This revision now requires review to proceed.Thu, May 16, 3:34 PM
rbranco_suse.com added a comment.Thu, May 16, 5:39 PM

I can confirm the patch works as intended.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 16, 5:54 PM
Closed by commit rG53725168e1b6: SysV SHM: move SHMSEG constants to sys/shm.h (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG53725168e1b6: SysV SHM: move SHMSEG constants to sys/shm.h.
kib added a commit: rG87a156527563: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines
sys/
4 lines

Diff 138624

View Options

sys/kern/sysv_shm.c

Loading...
View Options

sys/sys/shm.h

Loading...