mixer(8): Ignore mixer_open() failures for the -a option
ClosedPublic
Actions

Authored by christos on May 10 2024, 4:42 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGcd254b9243d3: mixer(8): Ignore mixer_open() failures for the -a option
rG0e80798518be: mixer(8): Ignore mixer_open() failures for the -a option

Summary

The most likely reason mixer_open() will fail is because either the
device doesn't exist, or because it is disabled, so there is not reason
to kill the application. Instead, continue and print the rest of the
enabled mixers.

PR: 277615
Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57654
Build 54542: arc lint + arc unit

Event Timeline

christos created this revision.May 10 2024, 4:42 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2024, 4:42 PM

christos requested review of this revision.May 10 2024, 4:42 PM

Harbormaster completed remote builds in B57654: Diff 138363.May 10 2024, 4:42 PM

christos added a parent revision: D45150: sound: Fix oss_sysinfo->nummixers.May 10 2024, 4:42 PM

christos mentioned this in D45150: sound: Fix oss_sysinfo->nummixers.May 10 2024, 4:50 PM

dev_submerge.ch accepted this revision.Mon, May 20, 3:28 PM

This revision is now accepted and ready to land.Mon, May 20, 3:28 PM

Closed by commit rG0e80798518be: mixer(8): Ignore mixer_open() failures for the -a option (authored by christos). · Explain WhyThu, May 23, 12:58 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG0e80798518be: mixer(8): Ignore mixer_open() failures for the -a option.

christos added a commit: rGcd254b9243d3: mixer(8): Ignore mixer_open() failures for the -a option.Sat, May 25, 7:32 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

mixer.c

2 lines

Diff 138363

View Options

mixer(8): Ignore mixer_open() failures for the -a optionClosedPublicActions