Page MenuHomeFreeBSD
Differential D45132

tftpd: Satisfy clang-analyzer.
ClosedPublic
Actions

Authored by des on May 8 2024, 5:57 PM.
Tags
None
Referenced Files
F99355356: D45132.diff
Tue, Oct 8, 6:38 PM
F99337360: D45132.diff
Tue, Oct 8, 1:32 PM
F99296934: D45132.id138283.diff
Tue, Oct 8, 3:47 AM
Unknown Object (File)
Mon, Oct 7, 3:56 PM
Unknown Object (File)
Mon, Oct 7, 12:32 PM
Unknown Object (File)
Mon, Oct 7, 12:32 PM
Unknown Object (File)
Sun, Oct 6, 11:16 PM
Unknown Object (File)
Sun, Oct 6, 10:09 AM
View All 60 Files
Subscribers
imp
markj

Details

Reviewers
imp
markj
Group Reviewers
Klara
Commits
rG4d09eb87c5d5: tftpd: Satisfy clang-analyzer.
Summary
  • Replace random() with arc4random().
  • Change some variable types.
  • Drop some unused assignments.

MFC after: 3 days
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57625
Build 54513: arc lint + arc unit

Event Timeline

des created this revision.May 8 2024, 5:57 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 8 2024, 5:57 PM
des requested review of this revision.May 8 2024, 5:57 PM
Harbormaster completed remote builds in B57625: Diff 138266.May 8 2024, 5:57 PM
imp accepted this revision.May 8 2024, 9:31 PM
This revision is now accepted and ready to land.May 8 2024, 9:31 PM
des retitled this revision from tftpd: Type nit. to tftpd: Satisfy clang-analyzer..May 9 2024, 10:52 AM
des updated this revision to Diff 138283.May 9 2024, 10:53 AM

more stuff

This revision now requires review to proceed.May 9 2024, 10:53 AM
Harbormaster completed remote builds in B57634: Diff 138283.May 9 2024, 10:53 AM
des edited the summary of this revision. (Show Details)May 9 2024, 11:07 AM
markj accepted this revision as: markj.May 9 2024, 3:37 PM
markj added a subscriber: markj.
markj added inline comments.
libexec/tftpd/tftp-io.c
80 ↗(On Diff #138283)

What's wrong with random() here? arc4random() is overkill for what this is doing.

This revision is now accepted and ready to land.May 9 2024, 3:37 PM
des added inline comments.May 9 2024, 3:52 PM
libexec/tftpd/tftp-io.c
80 ↗(On Diff #138283)

Agreed, this is solely to silence make analyze. I doubt this code ever gets used anyway, the option that enables it is undocumented and the test suite doesn't even glance in its direction.

Closed by commit rG4d09eb87c5d5: tftpd: Satisfy clang-analyzer. (authored by des). · Explain WhyMay 10 2024, 9:17 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG4d09eb87c5d5: tftpd: Satisfy clang-analyzer..
des mentioned this in rG626ee3cac845: tftpd: Add missing `-S` option to synopsis..May 14 2024, 6:59 AM

Revision Contents
Changeset List

PathSize
libexec/
tftpd/
4 lines

Diff 138266

View Options

libexec/tftpd/tftpd.c

Loading...