tftpd: Satisfy clang-analyzer.

• Replace random() with arc4random().
• Change some variable types.
• Drop some unused assignments.

MFC after: 3 days
Sponsored by: Klara, Inc.
Reviewed by: imp, markj
Differential Revision: https://reviews.freebsd.org/D45132