Page MenuHomeFreeBSD

Add options for mountd , nfsd and rpcbind
Needs RevisionPublic

Authored by joyul_juniper.net on May 7 2024, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 6:45 PM
Unknown Object (File)
May 14 2024, 2:51 PM
Unknown Object (File)
May 11 2024, 5:14 PM
Unknown Object (File)
May 8 2024, 9:07 AM
Unknown Object (File)
May 8 2024, 9:07 AM
Unknown Object (File)
May 8 2024, 6:28 AM

Details

Summary

In our products, we need those options to support our features.

  • Add daemon mode option for mountd, nfsd.
  • Add skip local host binding option for rpcd.
  • Add skip local host binding option for mountd.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joyul_juniper.net created this revision.

I've made some inline comments, but it looks generally ok to me.
All the man page updates require a change to the date (.Dd line)
and manpages should be asked for a group review.

Do you have a commit bit or do you want me to commit them?

usr.sbin/mountd/mountd.8
155

I would mention that this option is meaningless
unless -h has also been used.

usr.sbin/mountd/mountd.c
523

I'd suggest a warnx() here if (nhosts == 0 && skiplocalhost != 0)
indicating '-s" is being ignored.

usr.sbin/rpcbind/rpcbind.c
346

Although this program doesn't conform to style(9)
I would still use "nobind_localhost == 0" instead
of !nobind_localhost. I think it is more consistent
with the code around it and maybe more readable.

Thanks for taking the time to review it. Based on your feedback, I updated the patch.
And Yes, please help commit them.

In mountd.8, the capitalized flags are sorted before the lowercase flags. With those two changes, manpages LGTM

usr.sbin/mountd/mountd.8
107

107,110m100

152

152,158m171

This revision now requires changes to proceed.Thu, May 16, 8:19 PM