Implement UEFI set environment variable, as well as exporting the EFI version. This is also scriptable.

[imp]

Summary

Tested this in qemu ages ago. Was waiting for the userland version
to be complete before submitting, but thought it's better to have
half a loaf than none...

[emaste]

sys/boot/efi/libefi/env.c

2

18000 years too far in the future :)

[emaste]

sys/boot/efi/libefi/env.c

37–55

how are these used?

sys/boot/efi/loader/main.c

67

Interesting that this was here, unused.

126

Missing a format specifier?

sys/boot/ficl/efi.c

30

what's with the spacing here?

[smh]

A number of style issues

sys/boot/efi/libefi/env.c

2

Date typo

sys/boot/ficl/efi.c

50

Comment style could be better e.g.

/*
 * FreeBSD's loader works and extras
...
 */

70

Spacing after cast type unneeded more below

76

Should be != NULL as its not a boolean more instances below

91

Shouldn't have a final return for void functions more below

119

space after if

146

Should be != NULL as its not a boolean

164

no space needed

166

Alignment

[imp]

Looks like there's a missing hunk stuck in my patch queue, I'll merge it and
update the style nits for the next round.

sys/boot/efi/libefi/env.c

2

Doh! Will fix.

37–55

These are used to implement the different commands. I thought I'd included that as well in this review, but it appears to be missing. Will track down.

sys/boot/efi/loader/main.c

126

Doh! Yes.

sys/boot/ficl/efi.c

30

Other files did this too.

50

I'm sure I copied this from elsewhere in the loader code, but thanks.

166

These I'm pretty sure are aligned, but I'll do the style sweep.

[cem]

Makes me wish the boot language was anything other than Forth. :)

sys/boot/ficl/efi.c

61–64

Weird spacing here, too (and below) (style).

[allanjude]

sys/boot/ficl/efi.c

166

Phabricator has a "special" relationship with tabs

[emaste]

Waiting on fresh upload

[imp]

This kinda was committed, but kinda doesn't work. Will post new review when it's working.