Page MenuHomeFreeBSD

Implement UEFI set environment variable, as well as exporting the EFI version. This is also scriptable.
AbandonedPublic

Authored by imp on Dec 11 2015, 5:55 AM.
Tags
None
Referenced Files
F91735103: D4494.diff
Wed, Aug 21, 4:57 PM
Unknown Object (File)
Jul 2 2024, 7:48 PM
Unknown Object (File)
Feb 21 2024, 4:48 AM
Unknown Object (File)
Jan 14 2024, 4:35 AM
Unknown Object (File)
Dec 20 2023, 1:16 AM
Unknown Object (File)
Nov 8 2023, 11:47 AM
Unknown Object (File)
Nov 4 2023, 5:13 AM
Unknown Object (File)
Oct 30 2023, 4:16 PM

Details

Reviewers
emaste
Summary

Tested this in qemu ages ago. Was waiting for the userland version
to be complete before submitting, but thought it's better to have
half a loaf than none...

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1565
Build 1571: arc lint + arc unit

Event Timeline

imp retitled this revision from to Implement UEFI set environment variable, as well as exporting the EFI version. This is also scriptable..
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp added a reviewer: emaste.
sys/boot/efi/libefi/env.c
2

18000 years too far in the future :)

sys/boot/efi/libefi/env.c
37–55

how are these used?

sys/boot/efi/loader/main.c
67

Interesting that this was here, unused.

126

Missing a format specifier?

sys/boot/ficl/efi.c
30

what's with the spacing here?

A number of style issues

sys/boot/efi/libefi/env.c
2

Date typo

sys/boot/ficl/efi.c
50

Comment style could be better e.g.

/*
 * FreeBSD's loader works and extras
...
 */
70

Spacing after cast type unneeded more below

76

Should be != NULL as its not a boolean more instances below

91

Shouldn't have a final return for void functions more below

119

space after if

146

Should be != NULL as its not a boolean

164

no space needed

166

Alignment

Looks like there's a missing hunk stuck in my patch queue, I'll merge it and
update the style nits for the next round.

sys/boot/efi/libefi/env.c
2

Doh! Will fix.

37–55

These are used to implement the different commands. I thought I'd included that as well in this review, but it appears to be missing. Will track down.

sys/boot/efi/loader/main.c
126

Doh! Yes.

sys/boot/ficl/efi.c
30

Other files did this too.

50

I'm sure I copied this from elsewhere in the loader code, but thanks.

166

These I'm pretty sure are aligned, but I'll do the style sweep.

Makes me wish the boot language was anything other than Forth. :)

sys/boot/ficl/efi.c
61–64

Weird spacing here, too (and below) (style).

allanjude added inline comments.
sys/boot/ficl/efi.c
166

Phabricator has a "special" relationship with tabs

emaste requested changes to this revision.Dec 22 2015, 3:55 AM
emaste edited edge metadata.

Waiting on fresh upload

This revision now requires changes to proceed.Dec 22 2015, 3:55 AM

This kinda was committed, but kinda doesn't work. Will post new review when it's working.