iostat(8) should print statistics one more time on SIGINT.
ClosedPublic
Actions

Authored by asomers on Dec 9 2015, 5:22 PM.

Details

Reviewers

Commits

rS292019: When iostat(8) receives SIGINT while running with "-w" or "-c", it will now

Summary

When iostat(8) receives SIGINT while running with "-w" or "-c", it will now
print statistics one more time before exiting. Also, it now implements the
wait using setitimer instead of sleep, so the waits will be more consistent
when the system is heavily loaded.

Test Plan

Run iostat -w3
Generate some load on the tty by running "yes" on another console
Press CTRL-C on iostat's console
Verify that reasonable stats are printed one last time as iostat exits

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1528
Build 1534: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 10986.Dec 9 2015, 5:22 PM

asomers retitled this revision from to iostat(8) should print statistics one more time on SIGINT..

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: ken.

asomers added a subscriber: will.

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2015, 5:22 PM

Looks good to me, thanks!

In D4473#94114, @ken wrote:

Looks good to me, thanks!

If you're done, could you please Accept the revision?

Sure, looks good!

This revision is now accepted and ready to land.Dec 9 2015, 6:03 PM

Closed by commit rS292019: When iostat(8) receives SIGINT while running with "-w" or "-c", it will now (authored by asomers). · Explain WhyDec 9 2015, 6:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

iostat/

iostat.c

59 lines

Diff 10986

View Options

iostat(8) should print statistics one more time on SIGINT.ClosedPublicActions