Page MenuHomeFreeBSD

ptrace: Add a test using PROC_REAP_KILL to kill a stopped debuggee
ClosedPublic

Authored by markj on Mar 30 2024, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 17 2024, 4:36 PM
Unknown Object (File)
Jun 9 2024, 7:56 AM
Unknown Object (File)
Jun 2 2024, 12:21 PM
Unknown Object (File)
May 24 2024, 7:48 PM
Unknown Object (File)
May 16 2024, 1:15 AM
Unknown Object (File)
May 16 2024, 1:15 AM
Unknown Object (File)
May 16 2024, 1:15 AM
Unknown Object (File)
May 16 2024, 1:15 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Mar 30 2024, 2:20 PM

Remove some leftover debugging cruft

Why do you need the killer child to kill the debuggee?

I suppose the test is run in dedicated process, so the debuggee is automatically detached, continued, and then the zombie is gathered either by init or the test process?

This revision is now accepted and ready to land.Mar 30 2024, 2:43 PM
In D44564#1016180, @kib wrote:

Why do you need the killer child to kill the debuggee?

It's not strictly needed I think. It just help exercise more code paths in reap_kill_subtree_once().

I suppose the test is run in dedicated process, so the debuggee is automatically detached, continued, and then the zombie is gathered either by init or the test process?

Yes, ATF tests always run in a dedicated process, so we can let init reap zombies.

Make the test case useful. reap_kill() will not single-thread an
already-stopped process.

This revision now requires review to proceed.Mar 31 2024, 2:56 PM
This revision is now accepted and ready to land.Mar 31 2024, 6:03 PM