14
ClosedPublic
Actions

Authored by michaelo on Mar 13 2024, 1:36 PM.

Details

Reviewers

jrm
otis

Commits

R11:5e3da22d048f: print/ghostscript10: fix compilation issue with LLVM > 14

Summary

This issue reported upstream with
https://bugs.ghostscript.com/show_bug.cgi?id=707649 has been fixed and
one-off patch backported to this port.

PR: 277667
Approved by: jrm (mentor), otis (mentor)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Mar 13 2024, 1:36 PM

michaelo created this revision.

Harbormaster completed remote builds in B56577: Diff 135693.Mar 13 2024, 1:37 PM

mat added a subscriber: mat.Mar 13 2024, 2:25 PM

mat added inline comments.

print/ghostscript10/Makefile
3	Why bump PORTREVISION ?

michaelo added inline comments.Mar 13 2024, 2:27 PM

print/ghostscript10/Makefile
3	To trigger a rebuild in poudriere, the source code has changed after all.

I tested the patch and it works fine here in poudriere.

Thanks!

mat added inline comments.Mar 13 2024, 2:34 PM

print/ghostscript10/Makefile
3	Why are you adding a patch ?

vvd added a subscriber: vvd.Mar 13 2024, 2:43 PM

vvd added inline comments.

print/ghostscript10/Makefile
3	Build without errors on 13.2 (llvm 14), but it can fail in runtime.
34	Why `EXTRA_PATCHES`?

jrm added inline comments.Mar 13 2024, 2:47 PM

print/ghostscript10/Makefile
7–10	I slightly prefer fetching the patch from the source repository rather than copying and storing it in the ports tree. I'm just pointing out this is an option; it's not a blocker.

michaelo added inline comments.Mar 13 2024, 2:47 PM

print/ghostscript10/Makefile
34	I have fetched the patch straight out of Git and it we be removed with the next version of GS. No need to spend extra time to do the patch myself with `make makepatch`.

michaelo added inline comments.Mar 13 2024, 3:09 PM

print/ghostscript10/Makefile
7–10	Good to know, the reason why I did it I have copied the approach from fe495574527e3f97cbb57438f8c468fad8842e9d and it was accepted.

vishwin added a subscriber: vishwin.Mar 13 2024, 3:10 PM

vishwin added inline comments.

print/ghostscript10/Makefile
34	This is not needed when you already have `PATCH_SITES`/`PATCHFILES` for the same exact patch. In fact, this is a wasted line (and corresponding downloaded file) regardless, unless you explicitly do the patching in `do-patch`/`pre-patch`/`post-patch`.

jrm added inline comments.Mar 13 2024, 3:21 PM

print/ghostscript10/Makefile
3	@vvd Could you elaborate? Do you have an actionable suggestion for Michael?
7–10	For the Samba commit, it was unclear whether those patches were fetchable, and there already were a few entries in `EXTRA_PATCHES`, so it seemed preferable to keep the existing approach.

fetch patch from remote

Harbormaster completed remote builds in B56580: Diff 135697.Mar 13 2024, 3:22 PM

Removed inline patch in favor of remote one.

Looks good to me unless @vvd has something actionable regarding runtime issues.

print/ghostscript10/Makefile
3	I agree that it is useful to rebuild the port with the updated code, even when it is successfully built before the patch. Also, it's not like this is rebuilding LLVM or rust. On my modest hardware, poudriere tells me it took 27s to build.

This revision is now accepted and ready to land.Mar 13 2024, 3:35 PM

vvd added inline comments.Mar 13 2024, 3:44 PM