Page MenuHomeFreeBSD

newbus: Remove redundant check for 0
ClosedPublic

Authored by imp on Mar 7 2024, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 6:08 PM
Unknown Object (File)
Tue, Aug 11, 11:47 PM
Unknown Object (File)
Tue, Aug 11, 11:36 PM
Unknown Object (File)
Tue, Aug 4, 7:05 AM
Unknown Object (File)
Tue, Aug 4, 4:38 AM
Unknown Object (File)
Tue, Aug 4, 3:06 AM
Unknown Object (File)
Mon, Aug 3, 1:55 AM
Unknown Object (File)
Fri, Jul 31, 1:01 AM
Subscribers

Details

Summary

We already checked to see if the return code is 0 above. This code is
redundant.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Mar 7 2024, 7:15 PM

actually fix the redundancy

sys/kern/subr_bus.c
1670

I suppose this line could also be dropped.

1751

Maybe we finally need to implement strdup above.

jhb added inline comments.
sys/kern/subr_bus.c
1670

Yes, you can drop pri == 0

1671

out is ok, but you could also use something like exact_match or some other name for the label.

1751

Lots of description strings are constants rather than dynamically allocated. I don't think it would matter if we started always dynamically allocating them though.

This revision is now accepted and ready to land.Mar 13 2024, 8:40 PM
This revision was automatically updated to reflect the committed changes.