Page MenuHomeFreeBSD

nvme_sim: Allow administrative commands when we're marked as failed
AbandonedPublic

Authored by imp on Mar 1 2024, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 9:12 AM
Unknown Object (File)
Sat, Apr 27, 12:16 PM
Unknown Object (File)
Tue, Apr 23, 11:32 AM
Unknown Object (File)
Fri, Apr 19, 12:45 PM
Unknown Object (File)
Mar 27 2024, 7:03 AM
Unknown Object (File)
Mar 4 2024, 3:23 AM
Subscribers

Details

Reviewers
mav
chs
chuck
Summary

When we've marked the drive as failed, it may be possible to talk to it
in some limited sense via the administrative case. When the NAND fails,
or the FTL gets confused, I/O commands to the media will fail. But some
vendors have administative commands that can reset the FTL, so avoid
filtering those out. Worst case is the administrative commands will be
rejected by the drive or timeout. Best case is that we can get through
the commands that let us fix the drive and bring it back into service.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56390
Build 53278: arc lint + arc unit

Event Timeline

If you say it helps I have no objections, but I see nvme_sim_controller_fail() destroying SIM, so I am not sure you actually get here.

Hmmm... I'm not sure now... I thought I needed this, but I'll again without... and after I redo the failure stuff to allow the old consumers to come back... Or really if we should fail them and remove them...

I don't know what I was thinking here...