Page MenuHomeFreeBSD

kern/openzfs: Apply the essential part of FreeBSD-EN-23:18.openzfs. (stable/13)
ClosedPublic

Authored by seigo.tanimura_gmail.com on Mar 1 2024, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:30 AM
Unknown Object (File)
Mon, Nov 4, 4:15 AM
Unknown Object (File)
Wed, Oct 23, 2:05 PM
Unknown Object (File)
Fri, Oct 18, 9:33 AM
Unknown Object (File)
Fri, Oct 18, 9:33 AM
Unknown Object (File)
Thu, Oct 17, 5:03 PM
Unknown Object (File)
Wed, Oct 16, 9:15 PM
Unknown Object (File)
Mon, Oct 14, 10:04 PM

Details

Reviewers
olce
Summary

Avoid piling up the ARC pruning tasks when it is running.

The fix for FreeBSD-EN-23:18.openzfs is for OpenZFS 2.2, so it cannot be
applied directly to stable/13.

PR: 275594
Reported By: Thomas Mueller <thmu7@freenet.de>
Security: FreeBSD-EN-23:18.openzfs
Signed-off-by: Seigo Tanimura <seigo.tanimura@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56368
Build 53256: arc lint + arc unit

Event Timeline

Target branches: stable/13, releng/13.3, releng/13.2

seigo.tanimura_gmail.com retitled this revision from kern/openzfs: Apply the essential part of FreeBSD-EN-23:18.openzfs. to kern/openzfs: Apply the essential part of FreeBSD-EN-23:18.openzfs. (stable/13).Mar 3 2024, 12:17 AM

I agree with this simple, stopgap measure. It is indeed what FreeBSD-EN-23:18.openzfs achieves, in a much simpler way.

Just to be sure, I'm currently trying to reproduce some of the PR 275594's problems without and with this patch.

Then, going to liaise with upstream to see if they plan to MFC FreeBSD-EN-23:18.openzfs. If they don't, I'll push that patch upstream as well.

This revision is now accepted and ready to land.Apr 4 2024, 4:35 PM

Hello @olce,

Are you going to apply this change to stable/13 only, or "backport" it to main first?

I have to ask that because main and stable/14 already have the equivalent fix.

Hi Seigo,

Hello @olce,

Are you going to apply this change to stable/13 only, or "backport" it to main first?

I have to ask that because main and stable/14 already have the equivalent fix.

This change is to be applied to stable/13 only (obviously). So maybe I'm not understanding your question?

Sorry for the slow progress, I've been ill for a few days (hopefully coming to an end today/tomorrow) so could not work more than a few hours.

To clarify the next steps for this precise change:

  • Commit it to stable/13.
  • Ensure that either this fix or the full change in FreeBSD-EN-23:18.openzfs is committed to OpenZFS 2.1.x (so that, at the next import in stable/13, we don't lose the fix).
  • Possibly issue an EN for releng/13.3 (but for this we may wait a bit to see which other fixes should be included to solve/mitigate the reported problems).

Hello @olce,

This change is to be applied to stable/13 only (obviously). So maybe I'm not understanding your question?

That has clarified my question, thanks!

The upcoming steps looks good on my side as well.

Going to be superseded by a backport of FreeBSD-EN-23:18.openzfs to OpenZFS 2.1.x and FreeBSD's stable/13.

Please see the recent report in the bug (PR 275594).

Thanks.

Closing, since superseded by an upstream fix.