Paths

Table of Contentst

Differential D44038

gicv3: If the LPI is already allocated, remember it
ClosedPublic
Actions

Authored by imp on Feb 23 2024, 4:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 24, 9:34 PM

	Unknown Object (File)
	Mon, Jun 24, 6:02 PM

	Unknown Object (File)
	May 22 2024, 12:01 PM

	Unknown Object (File)
	May 22 2024, 5:02 AM

	Unknown Object (File)
	May 22 2024, 4:55 AM

	Unknown Object (File)
	May 22 2024, 3:31 AM

	Unknown Object (File)
	May 21 2024, 7:20 PM

	Unknown Object (File)
	May 19 2024, 2:31 PM

View All 17 Files

Subscribers

Details

Reviewers

andrew
manu

Commits

rGd476e51525ff: gicv3: If the LPI is already allocated, remember it
rGcb4a83cff01c: gicv3: If the LPI is already allocated, remember it

Summary

If the LPI has been pre-allocated by the boot loader, then we have to
remember PROPBASER and use it rather than allocating memory for it
ourselves. Linux provides us with a reserved table that contains all the
gicv3 allocates, so make sure what we read from PROPBASER matches
something in that table. Normally, the boot loader would leave the gic
in a reset state. However, Linux brings it up fully so it can do I/O to
boot the next kernel (us in this case). Since the gicv3 can't be
restarted due to undefined behavior, we have to use the mapping we
discover.

With this commit, the workaround is complete. Details are at
https://lkml.iu.edu/hypermail/linux/kernel/1809.2/06246.html
and pointers in the thread.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Feb 23 2024, 4:47 AM

Herald added a reviewer: andrew. · View Herald TranscriptFeb 23 2024, 4:47 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

imp requested review of this revision.Feb 23 2024, 4:47 AM

imp added a parent revision: D44037: gicv3: In its_init_cpu_lpi record each cpu's PENDBASER.

Harbormaster completed remote builds in B56183: Diff 134872.Feb 23 2024, 4:47 AM

imp mentioned this in D40902: arm64/gicv3: Allow us to inherit the LPI mappings.Feb 23 2024, 4:55 AM

Better panic message
Fix GICV3_ITS_MASK usage and definition

Harbormaster completed remote builds in B56200: Diff 134910.Feb 23 2024, 11:44 PM

With this, I can now boot on all the same hardware that the old, hacky version did.

andrew accepted this revision.Feb 27 2024, 10:19 AM

andrew added inline comments.

sys/arm64/arm64/gicv3_its.c
726–727	Should this be behind `bootverbose`?

This revision is now accepted and ready to land.Feb 27 2024, 10:19 AM

Review comments

This revision now requires review to proceed.Feb 27 2024, 4:31 PM

Harbormaster completed remote builds in B56264: Diff 135068.Feb 27 2024, 4:31 PM

Toss this message behind a bootverbose.

Harbormaster completed remote builds in B56307: Diff 135124.Feb 27 2024, 8:28 PM

andrew accepted this revision.Feb 28 2024, 10:20 AM

This revision is now accepted and ready to land.Feb 28 2024, 10:20 AM

Closed by commit rGcb4a83cff01c: gicv3: If the LPI is already allocated, remember it (authored by imp). · Explain WhyFeb 28 2024, 2:11 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGcb4a83cff01c: gicv3: If the LPI is already allocated, remember it.

imp added a commit: rGd476e51525ff: gicv3: If the LPI is already allocated, remember it.Apr 16 2024, 9:43 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

30 lines

Diff 135168

sys/arm64/arm64/gicv3_its.c

Loading...